You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Marcono1234 (Jira)" <ji...@apache.org> on 2023/07/23 13:32:00 UTC

[jira] [Created] (IMAGING-359) Faulty usage of URL.getFile() in tests

Marcono1234 created IMAGING-359:
-----------------------------------

             Summary: Faulty usage of URL.getFile() in tests
                 Key: IMAGING-359
                 URL: https://issues.apache.org/jira/browse/IMAGING-359
             Project: Commons Imaging
          Issue Type: Bug
            Reporter: Marcono1234


The unit tests contain a lot of code which obtains a {{URL}} from {{Class.getResource(String)}}, and then calls {{URL.getFile()}} to use that as file path.

The problem is that, despite sounding similar, {{URL.getFile()}} is completely unrelated to file paths and actually returns an URL encoded value. So what this means is that you encounter a lot of test failures due to {{NoSuchFileException}} if you have the project in a directory with space or non-ASCII characters in its file path.

The solution is to call {{URL.toURI()}} and then either {{new File(URI)}} or {{Paths.get(URI)}} (respectively {{Path.of(URI)}}).
Maybe a separate helper method shared by all test code is needed for this because {{toURI}} unfortunately throws a checked {{URISyntaxException}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)