You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/26 01:48:56 UTC
[GitHub] [skywalking] lzdujing opened a new issue #7571: The problem remains : NPE when thrift field is nested
lzdujing opened a new issue #7571:
URL: https://github.com/apache/skywalking/issues/7571
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ T] Question or discussion
- [ ] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Question
- What do you want to know?
I already used version 8.6.0 which has fixed the error: NPE when thrift field is nested ,but context is still null, why?
___
### Bug
- Which version of SkyWalking, OS, and JRE?
8.6.0
- Which company or project?
- What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.
context is null, why?
code position:
ServerInProtocolWrapper#readFieldBegin()
@Override
public TField readFieldBegin() throws TException {
................
if (field.type == TType.STOP) {
Boolean haveCreatedSpan =
(Boolean) ContextManager.getRuntimeContext().get(HAVE_CREATED_SPAN);
if (haveCreatedSpan != null && !haveCreatedSpan) {
try {
AbstractSpan span = ContextManager.createEntrySpan(
context.getOperatorName(), createContextCarrier(null));
span.start(context.startTime);
span.tag(TAG_ARGS, context.getArguments());
span.setComponent(ComponentsDefine.THRIFT_SERVER);
SpanLayer.asRPCFramework(span);
} catch (Throwable throwable) {
LOGGER.error("Failed to create EntrySpan.", throwable);
} finally {
context = null;
}
return field;
}
___
### Requirement or improvement
- Please describe your requirements or improvement suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-918695132
Fixed through https://github.com/apache/skywalking-java/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-909771073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-914871260
@dmsolr Ok,thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-909771073
@dmsolr Can this issue be reproduced?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dmsolr commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-906231366
Sure. I will try to reproduce this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dmsolr commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-917647570
Thanks, @zifeihan
Yes, I really didn't cover this case `TMultiplexedProcessor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-914847130
@wu-sheng Yes,I understand. We have tried our best to solve it and never give up.But It's a little hard for us . So we hope the community can help us and we expressing thanks for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-906226552
Hello, Wu Zong, I haved uploaded demo codes and description document to the github. Thank you for following it very much!
https://github.com/KeJemas/thriftDemo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-906020616
This error happened when my ThriftServer is resigister to nacos。If it not resigister to nacos，the problem not appeared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zifeihan commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
zifeihan commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-917642574
@dmsolr @lzdujing Sorry for being late. I have been too busy recently. Through debugging, I found that the thrift plugin processes TBaseProcessor and TBaseAsyncProcessor, but the demo reference uses TMultiplexedProcessor, so an exception has occurred. I am repairing and testing. I will submit pr tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-916564971
@lzdujing I'll provide a zip today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-918771351
@ zifeihan I have downloaded the last version and tested. It is ok now.Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dmsolr commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-909808088
@lzdujing Sorry. A tittle busy these days. I will do this on weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-914812745
> @dmsolr Could you take a look this issue for me sometime soon? We are waiting to solve the problem a little worry . Thank you.
@lzdujing The community is supported by volunteer, no matter they are using free time or work time. But, we always recommend you to debug and try to resolve issues rather than waiting.
There is never a timeline to say this has been to resolved. We had over 500+ contributors to solve different issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-917751642
Thank you very much. I'll check it tody.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-906022160
Please at least share the runnable demo codes with us, including how to run the codes locally. Your description is hard/impossible to follow for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zifeihan edited a comment on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
zifeihan edited a comment on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-917642574
@wu-sheng @dmsolr @lzdujing Sorry for being late. I have been too busy recently. Through debugging, I found that the thrift plugin processes TBaseProcessor and TBaseAsyncProcessor, but the demo reference uses TMultiplexedProcessor, so an exception has occurred. I am repairing and testing. I will submit pr tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zifeihan commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
zifeihan commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-918072363
It has been fixed, please refer to the latest version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-917780708
@ zifeihan After updating the code the problem of reporting errors has been solved,but,the server still can't track it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-916672621
@zifeihan I have uploaded the non-compressed demo already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7571:
URL: https://github.com/apache/skywalking/issues/7571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-906021730
this code is never executed , so ,context is null forever.
public void initial(AbstractContext context) {
this.context = context;
ContextManager.getRuntimeContext().put(HAVE_CREATED_SPAN, false);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zifeihan commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
zifeihan commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-916123888
@lzdujing Can you provide a zip to replace the rar package? In addition, the error log of the agent is also needed, which is a bit busy these days. I will take time to follow up on this issue during the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing removed a comment on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing removed a comment on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-916564971
@lzdujing I'll provide a zip today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-906012787
Please share the demo codes and error stack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-906024044
ok，I prepared later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-914809701
@dmsolr Could you take a look this issue for me sometime soon? We are waiting to solve the problem a little worry . Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dmsolr commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-914858901
Hi @lzdujing
I had talked with @zifeihan , he will follow this.
I am not familiar with Nacos, so that is my guess. It seems like thrift-plugin is not compatible with nacos sdk. Maybe nacos spring sdk will modify thrift classes in runtime.
BTW, you provided a `rar` package, that is hard to open in MacOS/Linux.
And this case happens in such a complex environment, I am really difficult to make it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zifeihan commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
zifeihan commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-917656896
@lzdujing It has been tested on your demo project, and the test results are all normal. I have been busy recently, so the related test scenario has not been added. If you have time, can you submit a pr to help cover the related test scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-909817786
@dmsolr ok,thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-906229504
@dmsolr Could you take a look when you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dmsolr commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-909808088
@lzdujing Sorry. A tittle busy these days. I will do this on weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lzdujing commented on issue #7571: The problem remains : NPE when thrift field is nested
Posted by GitBox <gi...@apache.org>.
lzdujing commented on issue #7571:
URL: https://github.com/apache/skywalking/issues/7571#issuecomment-916565169
@zifeihan I'll provide a zip today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org