You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Don Brown (JIRA)" <ji...@apache.org> on 2006/12/09 03:15:57 UTC
[jira] Created: (WW-1554) Dojo topic notification broken
Dojo topic notification broken
------------------------------
Key: WW-1554
URL: http://issues.apache.org/struts/browse/WW-1554
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.0.1
Reporter: Don Brown
Priority: Blocker
Fix For: 2.0.2
Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1554) Dojo topic notification broken
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1554?page=all ]
Musachy Barroso updated WW-1554:
--------------------------------
Attachment: WW-1554_Core.patch
/core is the root of the patch
> Dojo topic notification broken
> ------------------------------
>
> Key: WW-1554
> URL: http://issues.apache.org/struts/browse/WW-1554
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Don Brown
> Priority: Blocker
> Fix For: 2.0.2
>
> Attachments: indicator.gif, WW-1554.patch, WW-1554_1.patch, WW-1554_2.patch, WW-1554_Apps.patch, WW-1554_Core.patch
>
>
> Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1554) Dojo topic notification broken
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1554?page=comments#action_39082 ]
Musachy Barroso commented on WW-1554:
-------------------------------------
Well, there are two things with the hangman example, one is the creation of the widgets, it probably worked fine before with older versions of Dojo, but now when the widgets are created in the ajax callback, Dojo complains that widgets with those IDs already exists, that's why I added the destroyWidgets (memory failing here with the name :) ) function to destroy the widgets before creating the new ones.
The other thing is that notifyTopics is called twice, one before the request and one after, which makes the whole reloading twice. Those were the changes for hangman, everything else is for the notifyTopics, I just got lazy and put everything on the same patch, which is not probably a good idea :)
> Dojo topic notification broken
> ------------------------------
>
> Key: WW-1554
> URL: http://issues.apache.org/struts/browse/WW-1554
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Don Brown
> Priority: Blocker
> Fix For: 2.0.2
>
> Attachments: indicator.gif, WW-1554.patch, WW-1554_1.patch, WW-1554_2.patch
>
>
> Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WW-1554) Dojo topic notification broken
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1554?page=all ]
Ted Husted resolved WW-1554.
----------------------------
Resolution: Fixed
> Dojo topic notification broken
> ------------------------------
>
> Key: WW-1554
> URL: http://issues.apache.org/struts/browse/WW-1554
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Don Brown
> Assigned To: Ted Husted
> Priority: Blocker
> Fix For: 2.0.2
>
> Attachments: indicator.gif, WW-1554.patch, WW-1554_1.patch, WW-1554_2.patch, WW-1554_Apps.patch, WW-1554_Core.patch, WW-1554_Showcase.patch
>
>
> Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1554) Dojo topic notification broken
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1554?page=all ]
Musachy Barroso updated WW-1554:
--------------------------------
Attachment: WW-1554_Showcase.patch
/apps/showcase
> Dojo topic notification broken
> ------------------------------
>
> Key: WW-1554
> URL: http://issues.apache.org/struts/browse/WW-1554
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Don Brown
> Priority: Blocker
> Fix For: 2.0.2
>
> Attachments: indicator.gif, WW-1554.patch, WW-1554_1.patch, WW-1554_2.patch, WW-1554_Apps.patch, WW-1554_Core.patch, WW-1554_Showcase.patch
>
>
> Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1554) Dojo topic notification broken
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1554?page=all ]
Musachy Barroso updated WW-1554:
--------------------------------
Attachment: WW-1554_1.patch
use this one instead, it fixes a bug in IE
> Dojo topic notification broken
> ------------------------------
>
> Key: WW-1554
> URL: http://issues.apache.org/struts/browse/WW-1554
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Don Brown
> Priority: Blocker
> Fix For: 2.0.2
>
> Attachments: indicator.gif, WW-1554.patch, WW-1554_1.patch
>
>
> Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1554) Dojo topic notification broken
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1554?page=all ]
Musachy Barroso updated WW-1554:
--------------------------------
Attachment: indicator.gif
Plese add this image to:
apps/showcase/src/main/webapp/images/
> Dojo topic notification broken
> ------------------------------
>
> Key: WW-1554
> URL: http://issues.apache.org/struts/browse/WW-1554
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Don Brown
> Priority: Blocker
> Fix For: 2.0.2
>
> Attachments: indicator.gif, WW-1554.patch
>
>
> Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1554) Dojo topic notification broken
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1554?page=all ]
Musachy Barroso updated WW-1554:
--------------------------------
Attachment: WW-1554_2.patch
pass sourceId as parameter to "notifyTopics".
Fix hangman example, cleaning up widgets before reloading, and check for the "type" parameter of the "notifyTopics" to avoid loading twice.
> Dojo topic notification broken
> ------------------------------
>
> Key: WW-1554
> URL: http://issues.apache.org/struts/browse/WW-1554
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Don Brown
> Priority: Blocker
> Fix For: 2.0.2
>
> Attachments: indicator.gif, WW-1554.patch, WW-1554_1.patch, WW-1554_2.patch
>
>
> Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1554) Dojo topic notification broken
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1554?page=all ]
Ted Husted updated WW-1554:
---------------------------
Assignee: Ted Husted
> Dojo topic notification broken
> ------------------------------
>
> Key: WW-1554
> URL: http://issues.apache.org/struts/browse/WW-1554
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Don Brown
> Assigned To: Ted Husted
> Priority: Blocker
> Fix For: 2.0.2
>
> Attachments: indicator.gif, WW-1554.patch, WW-1554_1.patch, WW-1554_2.patch, WW-1554_Apps.patch, WW-1554_Core.patch, WW-1554_Showcase.patch
>
>
> Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WW-1554) Dojo topic notification broken
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1554?page=all ]
Ted Husted resolved WW-1554.
----------------------------
Resolution: Fixed
Just as a point of information ...
To a clean checkout, I applied WW-1554.patch and then ww-1554_1. During _1, three conflicts were reported. I resolved each one by accepting "theirs" over "mine".
Bind.js:54
BindDiv.js:91
Combobox.sj:295
Likewise in ww-1554_2.patch, there were conflicts in the same three files.
Bind.js:187
BindDiv.js:188
Combobox:300
In _Apps, there was but one.
index.jsp:16
_Core
autocompleter.java:149
Bind.js:47
BindDiv:52
ComnboBox:322
autocompleter.ftl:49
autocompleter-1.txt:17
autocompleter-2.txt:13
_Showcase
index.jsp:16
----
Everything seemd to test out fine afterwards (or at least better than before).
> Dojo topic notification broken
> ------------------------------
>
> Key: WW-1554
> URL: http://issues.apache.org/struts/browse/WW-1554
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Don Brown
> Assigned To: Ted Husted
> Priority: Blocker
> Fix For: 2.0.2
>
> Attachments: indicator.gif, WW-1554.patch, WW-1554_1.patch, WW-1554_2.patch, WW-1554_Apps.patch, WW-1554_Core.patch, WW-1554_Showcase.patch
>
>
> Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1554) Dojo topic notification broken
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1554?page=comments#action_39078 ]
Don Brown commented on WW-1554:
-------------------------------
Boy, all sorts of changes here :) I'm looking at the hangman changes and I'm a little concerned: why do we need to modify the example when it was working before? I take the fact that it is broken as an indication that we still have bugs in our changed tags.
> Dojo topic notification broken
> ------------------------------
>
> Key: WW-1554
> URL: http://issues.apache.org/struts/browse/WW-1554
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Don Brown
> Priority: Blocker
> Fix For: 2.0.2
>
> Attachments: indicator.gif, WW-1554.patch, WW-1554_1.patch, WW-1554_2.patch
>
>
> Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1554) Dojo topic notification broken
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1554?page=all ]
Musachy Barroso updated WW-1554:
--------------------------------
Attachment: WW-1554_Apps.patch
/Apps is the root of the patch
> Dojo topic notification broken
> ------------------------------
>
> Key: WW-1554
> URL: http://issues.apache.org/struts/browse/WW-1554
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Don Brown
> Priority: Blocker
> Fix For: 2.0.2
>
> Attachments: indicator.gif, WW-1554.patch, WW-1554_1.patch, WW-1554_2.patch, WW-1554_Apps.patch
>
>
> Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (WW-1554) Dojo topic notification broken
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1554?page=all ]
Ted Husted reopened WW-1554:
----------------------------
After applying this patch, I noticed that the autocomplete tag for the ajax theme is broken in that it does not display the dropdown list.
There were a number of conflicts when applying the patch, and it's possible (even likely) that I selected the wrong resolution somewhere. My intent was to select the later code ("theirs") in each case.
Notes:
* The problem is not the JSP, since the page from 490075 doesn't work any better.
* The problem is not the href attribute, since using the list from the simple tag doesn't work either.
I'm out of town Thursday and Friday, so if a quickfix is not forhtcoming, I'll have to roll back the 40+ files tonight.
> Dojo topic notification broken
> ------------------------------
>
> Key: WW-1554
> URL: http://issues.apache.org/struts/browse/WW-1554
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Don Brown
> Assigned To: Ted Husted
> Priority: Blocker
> Fix For: 2.0.2
>
> Attachments: indicator.gif, WW-1554.patch, WW-1554_1.patch, WW-1554_2.patch, WW-1554_Apps.patch, WW-1554_Core.patch, WW-1554_Showcase.patch
>
>
> Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1554) Dojo topic notification broken
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1554?page=all ]
Musachy Barroso updated WW-1554:
--------------------------------
Attachment: WW-1554.patch
> Dojo topic notification broken
> ------------------------------
>
> Key: WW-1554
> URL: http://issues.apache.org/struts/browse/WW-1554
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Don Brown
> Priority: Blocker
> Fix For: 2.0.2
>
> Attachments: WW-1554.patch
>
>
> Since WebWork 2.2, certain components supported a "notifyTopics" attribute that had dojo send a topic notification when a link was clicked. Our hangman example in the showcase depends on this feature. This attribute, and several others, are now ignored in the anchor tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira