You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2023/01/13 13:28:28 UTC

[GitHub] [rocketmq] absolute8511 opened a new pull request, #5879: fix: dledger commit log should override the getData

absolute8511 opened a new pull request, #5879:
URL: https://github.com/apache/rocketmq/pull/5879

   Change-Id: I665c5b9d7e96c5b7ccd035b32272be7223d7f454
   
   
   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   XXXXX
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #5879: fix: dledger commit log should override the getData

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on code in PR #5879:
URL: https://github.com/apache/rocketmq/pull/5879#discussion_r1070249182


##########
store/src/test/java/org/apache/rocketmq/store/timer/TimerMessageStoreTest.java:
##########
@@ -211,6 +224,16 @@ public Boolean call() {
         }
     }
 
+    @Test
+    public void testPutTimerMessage1() throws Exception {
+        testPutTimerMessageCommon();
+    }
+
+    @Test
+    public void testPutTimerMessage2() throws Exception {
+        testPutTimerMessageCommon();
+    }

Review Comment:
   It is also possible that you will not run DLedger mode after running twice. It is recommended to set parameters or flag bits to determine which mode to run.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] absolute8511 commented on a diff in pull request #5879: [ISSUE #5883] fix: dledger commit log should override the getData

Posted by "absolute8511 (via GitHub)" <gi...@apache.org>.
absolute8511 commented on code in PR #5879:
URL: https://github.com/apache/rocketmq/pull/5879#discussion_r1089626925


##########
store/src/test/java/org/apache/rocketmq/store/timer/TimerMessageStoreTest.java:
##########
@@ -211,8 +220,31 @@ public Boolean call() {
         }
     }
 
+    @Test
+    public void testPutTimerMessage() throws Exception {
+        initStore(false);
+        testPutTimerMessageCommon();
+    }
+
+    @Test
+    public void testDledgerPutTimerMessage() throws Exception {
+        initStore(true);
+        testPutTimerMessageCommon();
+    }
+
     @Test
     public void testTimerFlowControl() throws Exception {
+        initStore(false);
+        testTimerFlowControlCommon();
+    }
+
+    @Test
+    public void testDledgerTimerFlowControl() throws Exception {
+        initStore(true);
+        testTimerFlowControlCommon();
+    }

Review Comment:
   OK, I removed some of them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] absolute8511 commented on a diff in pull request #5879: [ISSUE #5883] fix: dledger commit log should override the getData

Posted by "absolute8511 (via GitHub)" <gi...@apache.org>.
absolute8511 commented on code in PR #5879:
URL: https://github.com/apache/rocketmq/pull/5879#discussion_r1125599462


##########
store/src/test/java/org/apache/rocketmq/store/timer/TimerMessageStoreTest.java:
##########
@@ -211,8 +220,31 @@ public Boolean call() {
         }
     }
 
+    @Test
+    public void testPutTimerMessage() throws Exception {
+        initStore(false);
+        testPutTimerMessageCommon();
+    }
+
+    @Test
+    public void testDledgerPutTimerMessage() throws Exception {
+        initStore(true);
+        testPutTimerMessageCommon();
+    }
+
     @Test
     public void testTimerFlowControl() throws Exception {
+        initStore(false);
+        testTimerFlowControlCommon();
+    }
+
+    @Test
+    public void testDledgerTimerFlowControl() throws Exception {
+        initStore(true);
+        testTimerFlowControlCommon();
+    }

Review Comment:
   OK, I removed other test cases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #5879: [ISSUE #5883] fix: dledger commit log should override the getData

Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin commented on code in PR #5879:
URL: https://github.com/apache/rocketmq/pull/5879#discussion_r1088735121


##########
store/src/test/java/org/apache/rocketmq/store/timer/TimerMessageStoreTest.java:
##########
@@ -211,8 +220,31 @@ public Boolean call() {
         }
     }
 
+    @Test
+    public void testPutTimerMessage() throws Exception {
+        initStore(false);
+        testPutTimerMessageCommon();
+    }
+
+    @Test
+    public void testDledgerPutTimerMessage() throws Exception {
+        initStore(true);
+        testPutTimerMessageCommon();
+    }
+
     @Test
     public void testTimerFlowControl() throws Exception {
+        initStore(false);
+        testTimerFlowControlCommon();
+    }
+
+    @Test
+    public void testDledgerTimerFlowControl() throws Exception {
+        initStore(true);
+        testTimerFlowControlCommon();
+    }

Review Comment:
   Such a test is effective, but it will increase the test run time. I suggest writing a single test or temporarily not adding the test related to DLedger.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] codecov-commenter commented on pull request #5879: [ISSUE #5883] fix: dledger commit log should override the getData

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #5879:
URL: https://github.com/apache/rocketmq/pull/5879#issuecomment-1383097087

   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#5879](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8dbb8c4) into [develop](https://codecov.io/gh/apache/rocketmq/commit/5b64ffc9e86126342d2a441849124098e6e909ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5b64ffc) will **decrease** coverage by `0.04%`.
   > The diff coverage is `30.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #5879      +/-   ##
   =============================================
   - Coverage      42.43%   42.39%   -0.05%     
   - Complexity      8277     8278       +1     
   =============================================
     Files           1066     1066              
     Lines          73671    73683      +12     
     Branches        9630     9634       +4     
   =============================================
   - Hits           31261    31235      -26     
   - Misses         38460    38490      +30     
   - Partials        3950     3958       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...pache/rocketmq/store/dledger/DLedgerCommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2RsZWRnZXIvRExlZGdlckNvbW1pdExvZy5qYXZh) | `78.22% <30.00%> (-0.17%)` | :arrow_down: |
   | [...tmq/remoting/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL2JvZHkvQ29uc3VtZXJDb25uZWN0aW9uLmphdmE=) | `95.83% <0.00%> (-4.17%)` | :arrow_down: |
   | [...a/org/apache/rocketmq/broker/BrokerController.java](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | `43.29% <0.00%> (-2.86%)` | :arrow_down: |
   | [...pache/rocketmq/remoting/common/RemotingHelper.java](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL2NvbW1vbi9SZW1vdGluZ0hlbHBlci5qYXZh) | `15.38% <0.00%> (-2.31%)` | :arrow_down: |
   | [...pl/consumer/ConsumeMessageConcurrentlyService.java](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZUNvbmN1cnJlbnRseVNlcnZpY2UuamF2YQ==) | `46.60% <0.00%> (-2.27%)` | :arrow_down: |
   | [...mq/store/ha/autoswitch/AutoSwitchHAConnection.java](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL2F1dG9zd2l0Y2gvQXV0b1N3aXRjaEhBQ29ubmVjdGlvbi5qYXZh) | `70.00% <0.00%> (-1.36%)` | :arrow_down: |
   | [...apache/rocketmq/store/ha/GroupTransferService.java](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL0dyb3VwVHJhbnNmZXJTZXJ2aWNlLmphdmE=) | `92.30% <0.00%> (-1.29%)` | :arrow_down: |
   | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `61.23% <0.00%> (-0.45%)` | :arrow_down: |
   | [.../main/java/org/apache/rocketmq/common/UtilAll.java](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vVXRpbEFsbC5qYXZh) | `36.09% <0.00%> (-0.44%)` | :arrow_down: |
   | [.../org/apache/rocketmq/proxy/config/ProxyConfig.java](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2NvbmZpZy9Qcm94eUNvbmZpZy5qYXZh) | `44.65% <0.00%> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/rocketmq/pull/5879?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] absolute8511 commented on a diff in pull request #5879: [ISSUE #5883] fix: dledger commit log should override the getData

Posted by GitBox <gi...@apache.org>.
absolute8511 commented on code in PR #5879:
URL: https://github.com/apache/rocketmq/pull/5879#discussion_r1070505318


##########
store/src/test/java/org/apache/rocketmq/store/timer/TimerMessageStoreTest.java:
##########
@@ -211,6 +224,16 @@ public Boolean call() {
         }
     }
 
+    @Test
+    public void testPutTimerMessage1() throws Exception {
+        testPutTimerMessageCommon();
+    }
+
+    @Test
+    public void testPutTimerMessage2() throws Exception {
+        testPutTimerMessageCommon();
+    }

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #5879: [ISSUE #5883] fix: dledger commit log should override the getData

Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin commented on code in PR #5879:
URL: https://github.com/apache/rocketmq/pull/5879#discussion_r1118386090


##########
store/src/test/java/org/apache/rocketmq/store/timer/TimerMessageStoreTest.java:
##########
@@ -211,8 +220,31 @@ public Boolean call() {
         }
     }
 
+    @Test
+    public void testPutTimerMessage() throws Exception {
+        initStore(false);
+        testPutTimerMessageCommon();
+    }
+
+    @Test
+    public void testDledgerPutTimerMessage() throws Exception {
+        initStore(true);
+        testPutTimerMessageCommon();
+    }
+
     @Test
     public void testTimerFlowControl() throws Exception {
+        initStore(false);
+        testTimerFlowControlCommon();
+    }
+
+    @Test
+    public void testDledgerTimerFlowControl() throws Exception {
+        initStore(true);
+        testTimerFlowControlCommon();
+    }

Review Comment:
   > OK, I removed some of them.
   
   I suggest removing all tests temporarily and merge ASAP. Other PR can be subbmitted later to increase UTs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] RongtongJin merged pull request #5879: [ISSUE #5883] Dledger commit log should override the getData

Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #5879:
URL: https://github.com/apache/rocketmq/pull/5879


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org