[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5794: [TE] make rca insights in email resilient to issues in rca response

[GitBox <gi...@apache.org>]

akshayrai commented on a change in pull request #5794:
URL: https://github.com/apache/incubator-pinot/pull/5794#discussion_r465275426



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/SummaryResource.java
##########
@@ -172,6 +158,57 @@ public String buildSummary(
         response = SummaryResponse.buildNotAvailableResponse(datasetName, metricName);
       }
     }
+
+    return response;
+  }
+
+  @GET
+  @Path(value = "/summary/autoDimensionOrder/v2")
+  @Produces(MediaType.APPLICATION_JSON)
+  public Map<String, Object> getDataCubeSummary(
+      @QueryParam(METRIC_URN) String metricUrn,
+      @QueryParam("dataset") String dataset,
+      @QueryParam("metric") String metric,
+      @QueryParam(CURRENT_START) long currentStartInclusive,
+      @QueryParam(CURRENT_END) long currentEndExclusive,
+      @QueryParam(BASELINE_START) long baselineStartInclusive,
+      @QueryParam(BASELINE_END) long baselineEndExclusive,
+      @QueryParam("dimensions") String groupByDimensions,
+      @QueryParam("filters") String filterJsonPayload,
+      @QueryParam(CUBE_SUMMARY_SIZE) int summarySize,
+      @QueryParam(CUBE_DEPTH) @DefaultValue(DEFAULT_DEPTH) int depth,
+      @QueryParam(CUBE_DIM_HIERARCHIES) @DefaultValue(DEFAULT_HIERARCHIES) String hierarchiesPayload,
+      @QueryParam(CUBE_ONE_SIDE_ERROR) @DefaultValue(DEFAULT_ONE_SIDE_ERROR) boolean doOneSideError,
+      @QueryParam(CUBE_EXCLUDED_DIMENSIONS) @DefaultValue(DEFAULT_EXCLUDED_DIMENSIONS) String excludedDimensions,
+      @QueryParam(TIME_ZONE) @DefaultValue(DEFAULT_TIMEZONE_ID) String timeZone) throws Exception {
+    SummaryResponse response = buildDataCubeSummary(metricUrn, metric, dataset, currentStartInclusive, currentEndExclusive, baselineStartInclusive,
+        baselineEndExclusive, groupByDimensions, filterJsonPayload, summarySize, depth, hierarchiesPayload,
+        doOneSideError, excludedDimensions, timeZone);
+    return OBJECT_MAPPER.convertValue(response, Map.class);
+  }
+
+  @GET
+  @Path(value = "/summary/autoDimensionOrder")
+  @Produces(MediaType.APPLICATION_JSON)
+  public String buildSummary(

Review comment:
       This API is being consumed by some clients. Hence retained it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org