You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/04 15:45:39 UTC
[GitHub] [maven-integration-testing] psiroky opened a new pull request, #224: [MNG-7661] Fix deprecated verifier calls
psiroky opened a new pull request, #224:
URL: https://github.com/apache/maven-integration-testing/pull/224
* I know the change looks huge, but in fact it is just a couple of find & replace calls in IDE. 99% were of the changes were done automatically, just had to manually adjust some edge cases
* Each change has its own commit since they are kind of independent (the build should pass after each of those)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #224: [MNG-7661] Fix deprecated verifier calls
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #224:
URL: https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061706611
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng1803PomValidationErrorIncludesLineNumberTest.java:
##########
@@ -64,7 +64,6 @@ public void testit()
}
finally
{
- verifier.resetStreams();
}
Review Comment:
Empty finally block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #224: [MNG-7661] Remove deprecated 'verifier.resetStreams()'
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #224:
URL: https://github.com/apache/maven-integration-testing/pull/224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] psiroky commented on a diff in pull request #224: [MNG-7661] Remove deprecated 'verifier.resetStreams()'
Posted by GitBox <gi...@apache.org>.
psiroky commented on code in PR #224:
URL: https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061811833
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2199ParentVersionRangeTest.java:
##########
@@ -100,7 +89,6 @@ public void testValidParentVersionRangeWithExclusiveUpperBound()
{
if ( verifier != null )
{
- verifier.resetStreams();
Review Comment:
Hmm, there is more of these here :facepalm: . Will fix those as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] psiroky commented on pull request #224: [MNG-7661] Fix deprecated verifier calls
Posted by GitBox <gi...@apache.org>.
psiroky commented on PR #224:
URL: https://github.com/apache/maven-integration-testing/pull/224#issuecomment-1371323243
I will leave this PR for the first change (remvoing `resetStreams()`) and will create two more PR with the other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #224: [MNG-7661] Fix deprecated verifier calls
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #224:
URL: https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061707521
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2199ParentVersionRangeTest.java:
##########
@@ -65,7 +65,6 @@ public void testValidParentVersionRangeWithInclusiveUpperBound()
{
if ( verifier != null )
{
- verifier.resetStreams();
}
}
Review Comment:
empty if and finally ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #224: [MNG-7661] Fix deprecated verifier calls
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #224:
URL: https://github.com/apache/maven-integration-testing/pull/224#issuecomment-1371201704
Great job, can you split each commit as separate PR 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] psiroky commented on a diff in pull request #224: [MNG-7661] Remove deprecated 'verifier.resetStreams()'
Posted by GitBox <gi...@apache.org>.
psiroky commented on code in PR #224:
URL: https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061832128
##########
core-it-suite/src/test/java/org/apache/maven/it/ItUtils.java:
##########
@@ -19,7 +19,6 @@
* under the License.
*/
-import org.junit.jupiter.api.Test;
Review Comment:
This is unrelated, but it's an unused import, so hopefully fine to remove it as part of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] psiroky commented on a diff in pull request #224: [MNG-7661] Fix deprecated verifier calls
Posted by GitBox <gi...@apache.org>.
psiroky commented on code in PR #224:
URL: https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061809167
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng1803PomValidationErrorIncludesLineNumberTest.java:
##########
@@ -64,7 +64,6 @@ public void testit()
}
finally
{
- verifier.resetStreams();
}
Review Comment:
Fixed, thanks for spotting this.
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2199ParentVersionRangeTest.java:
##########
@@ -65,7 +65,6 @@ public void testValidParentVersionRangeWithInclusiveUpperBound()
{
if ( verifier != null )
{
- verifier.resetStreams();
}
}
Review Comment:
Fixed, thanks for spotting this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] psiroky commented on a diff in pull request #224: [MNG-7661] Remove deprecated 'verifier.resetStreams()'
Posted by GitBox <gi...@apache.org>.
psiroky commented on code in PR #224:
URL: https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061817082
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3331ModulePathNormalizationTest.java:
##########
@@ -68,7 +68,6 @@ public void testitMNG3331a ()
* Reset the streams before executing the verifier
Review Comment:
Removing these comments as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] psiroky commented on pull request #224: [MNG-7661] Remove deprecated 'verifier.resetStreams()'
Posted by GitBox <gi...@apache.org>.
psiroky commented on PR #224:
URL: https://github.com/apache/maven-integration-testing/pull/224#issuecomment-1371351037
I went through the diff (as best as I could considering the number of changed files), found couple more discrepancies and fixed them. Please take another look. Hopefully I got them all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org