You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "James Peach (JIRA)" <ji...@apache.org> on 2014/05/29 17:17:01 UTC
[jira] [Commented] (TS-2859) fix DBG macros to not generate
warnings from GCC 4.9
[ https://issues.apache.org/jira/browse/TS-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012435#comment-14012435 ]
James Peach commented on TS-2859:
---------------------------------
Thanks for the patch Marcin. These macros look obsolete and unused. Could you submit a path that simply removes them?
> fix DBG macros to not generate warnings from GCC 4.9
> ----------------------------------------------------
>
> Key: TS-2859
> URL: https://issues.apache.org/jira/browse/TS-2859
> Project: Traffic Server
> Issue Type: Improvement
> Components: Build
> Reporter: Marcin Juszkiewicz
> Attachments: trafficserver-fix-dbg.patch
>
>
> Fedora 'rawhide' is using gcc 4.9 as default compiler. During build of trafficserver 4.2.1 I had lot of extra output from gcc due to DBG macros:
> -----------------------------------------------------------------------------------
> In file included from ../../lib/ts/ink_time.h:38:0,
> from ../../lib/ts/ink_align.h:28,
> from ../../lib/ts/libts.h:46,
> from P_EventSystem.h:34,
> from IOBuffer.cc:28:
> ../../lib/ts/ink_defs.h:147:56: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
> #define FDBG if (debug_level==1) printf("debug "__FILE__":%d %s : entered\n" ,__LINE__,__FUNCTION__)
> ^
> ../../lib/ts/ink_defs.h:148:56: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG(s) if (debug_level==1) printf("debug "__FILE__":%d %s :" s ,__LINE__,__FUNCTION__)
> ^
> ../../lib/ts/ink_defs.h:149:56: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG1(s,a) if (debug_level==1) printf("debug "__FILE__":%d %s :" s ,__LINE__,__FUNCTION__, a)
> ^
> ../../lib/ts/ink_defs.h:150:56: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG2(s,a1,a2) if (debug_level==1) printf("debug "__FILE__":%d %s :" s ,__LINE__,__FUNCTION__, a1,a2)
> ^
> ../../lib/ts/ink_defs.h:151:56: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG3(s,a1,a2,a3) if (debug_level==1) printf("debug "__FILE__":%d %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3)
> ^
> ../../lib/ts/ink_defs.h:152:56: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG4(s,a1,a2,a3,a4) if (debug_level==1) printf("debug "__FILE__":%d %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3,a4)
> -----------------------------------------------------------------------------------
> I have a fix for that.
--
This message was sent by Atlassian JIRA
(v6.2#6252)