You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by pi...@apache.org on 2015/01/21 21:07:17 UTC

[4/6] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34712 bug fix for callout

FLEX-34712 bug fix for callout

Created function queued_systemManager_resizeHandler() and moved code from systemManager_resizeHandler() to that new function. New function is called via callLater() from original systemManager_resizeHandler(), allowing for calculatePopUpPosition() to get correct x and y.

Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/ba0144f5
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/ba0144f5
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/ba0144f5

Branch: refs/heads/develop
Commit: ba0144f5f9d97d02246dfa4b89b21188ae060199
Parents: 706eb34
Author: Kevin Godell <ke...@gmail.com>
Authored: Sat Jan 10 06:58:56 2015 -0600
Committer: Kevin Godell <ke...@gmail.com>
Committed: Sat Jan 10 06:58:56 2015 -0600

----------------------------------------------------------------------
 .../spark/src/spark/components/Callout.as       | 35 +++++++++++---------
 1 file changed, 19 insertions(+), 16 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/ba0144f5/frameworks/projects/spark/src/spark/components/Callout.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/src/spark/components/Callout.as b/frameworks/projects/spark/src/spark/components/Callout.as
index bfbb603..dec204a 100644
--- a/frameworks/projects/spark/src/spark/components/Callout.as
+++ b/frameworks/projects/spark/src/spark/components/Callout.as
@@ -1685,24 +1685,27 @@ public class Callout extends SkinnablePopUpContainer
     {
     	//callLater() solves bug FLEX-34712 only affecting device and not found on simulator
     	//where calculatePopUpPosition()'s correct x or y may not be immediately available
-        callLater(
-            function():void
-            {
-                // Remove explicit settings if due to Resize effect
-                softKeyboardEffectResetExplicitSize();
+        callLater(queued_systemManager_resizeHandler, [event]);
+    }
+    
+    /**
+     *  @private
+     */
+    private function queued_systemManager_resizeHandler(event:Event):void
+    {
+        // Remove explicit settings if due to Resize effect
+        softKeyboardEffectResetExplicitSize();
         
-                // Screen resize might require a new arrow direction and callout position
-                invalidatePosition();
+        // Screen resize might require a new arrow direction and callout position
+        invalidatePosition();
         
-                if (!isSoftKeyboardEffectActive)
-                {
-                    // Force validation and use new screen size only if the keyboard
-                    // effect is not active. The stage dimensions may be invalid while 
-                    // the soft keyboard is active. See SDK-31860.
-                    validateNow();
-                }
-            }
-        );
+        if (!isSoftKeyboardEffectActive)
+        {
+            // Force validation and use new screen size only if the keyboard
+            // effect is not active. The stage dimensions may be invalid while 
+            // the soft keyboard is active. See SDK-31860.
+            validateNow();
+        }
     }
 }
 }