You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Roshan Naik <ro...@hortonworks.com> on 2014/02/07 10:30:54 UTC
Review Request 17839: Updating TestExecSource to use windows commands when
running on windows
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17839/
-----------------------------------------------------------
Review request for Flume.
Bugs: FLUME-2151
https://issues.apache.org/jira/browse/FLUME-2151
Repository: flume-git
Description
-------
Porting TestExecSource tests to Windows
Diffs
-----
flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 54f71a1
flume-ng-core/src/test/resources/test_command.ps1 PRE-CREATION
Diff: https://reviews.apache.org/r/17839/diff/
Testing
-------
Thanks,
Roshan Naik
Re: Review Request 17839: Updating TestExecSource to use windows commands
when running on windows
Posted by Ashish Paliwal <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17839/#review34692
-----------------------------------------------------------
flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
<https://reviews.apache.org/r/17839/#comment64906>
Minor: Can we use JUnit rules for managing these files?
- Ashish Paliwal
On Feb. 7, 2014, 9:30 a.m., Roshan Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17839/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2014, 9:30 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2151
> https://issues.apache.org/jira/browse/FLUME-2151
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Porting TestExecSource tests to Windows
>
>
> Diffs
> -----
>
> flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 54f71a1
> flume-ng-core/src/test/resources/test_command.ps1 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17839/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roshan Naik
>
>