You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/09/19 23:05:35 UTC
[PR] Replace the deprecated Doxia Renderer with SiteRenderer [maven-reporting-impl]
slachiewicz opened a new pull request, #251:
URL: https://github.com/apache/maven-reporting-impl/pull/251
Doxia Sitetools 2.0.0 deprecated `Renderer` as an empty subinterface of `SiteRenderer`; this switches the protected `siteRenderer` field and `getSiteRenderer()` to `SiteRenderer`.
Source compatibility for reporting plugins is kept: a subclass overriding `getSiteRenderer()` with the old `Renderer` return type is a covariant override and still compiles (maven-changelog-plugin does this). The change is binary-incompatible for a subclass compiled against the old field type that reads `siteRenderer` directly, so it may be better placed on the next minor than on 4.0.1.
Verified: `mvn verify -Dmaven.compiler.showDeprecation=true` under JDK 17 → the `Renderer` warning is gone, 6 ITs passed. The remaining deprecations in `AbstractMavenReport` (`ReaderFactory`, `WriterFactory.UTF_8`, `SiteTool.getSiteModel` overload, `MessageBuilder.toString`) are out of scope here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace the deprecated API used in AbstractMavenReport [maven-reporting-impl]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #251:
URL: https://github.com/apache/maven-reporting-impl/pull/251#issuecomment-5749642328
> > Most important question: Do all of our callers use the non-deprecated API?
> > if all our callers mean - other apache/maven-* propably answer woudl be no as this was never propagted fuly. found few places about that. But as will progress with upgrades i''ll also resolve isues and migrate
Yes, this is what I mean that all projects are clean of deprecations and released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace the deprecated API used in AbstractMavenReport [maven-reporting-impl]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #251:
URL: https://github.com/apache/maven-reporting-impl/pull/251#issuecomment-5748889728
Most important question: Do all of our callers use the non-deprecated API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace the deprecated API used in AbstractMavenReport [maven-reporting-impl]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #251:
URL: https://github.com/apache/maven-reporting-impl/pull/251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace the deprecated API used in AbstractMavenReport [maven-reporting-impl]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #251:
URL: https://github.com/apache/maven-reporting-impl/pull/251#issuecomment-5749562758
> Most important question: Do all of our callers use the non-deprecated API?
if all our callers mean - other apache/maven-* propably answer woudl be no as this was never propagted fuly. found few places about that. But as will progress with upgrades i''ll also resolve isues and migrate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace the deprecated API used in AbstractMavenReport [maven-reporting-impl]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #251:
URL: https://github.com/apache/maven-reporting-impl/pull/251#issuecomment-5750091806
Yes, i've fixed it (1 occurence) and PR description has been updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org