You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/08/29 09:40:28 UTC
[PR] refactor(desktop): remove internal compatibility facades [maka]
Astro-Han opened a new pull request, #4151:
URL: https://github.com/apache/maka/pull/4151
## Summary
Remove two completed Desktop migration layers:
- import shared thread search directly from `@maka/core/thread-search` and delete the Desktop forwarding module
- import the Computer Use PIP feed from its owner and remove the migration-only re-exports from the PIP controller
The PIP controller/lifecycle and shared search implementation remain unchanged, so this reduces internal API surface without changing behavior.
## Verification
- `node --test apps/desktop/dist/main/__tests__/thread-search.test.js apps/desktop/dist/main/__tests__/runtime-host-search-ipc-main.test.js` — 20 passed
- `npm --workspace @maka/desktop run typecheck` — passed, including main, preload, renderer, and Storybook configs
- `npm run format:check` — passed across 1771 files
- merge-tree checked against open PR #4010: both overlapping Desktop files auto-merge; its existing conflicts remain limited to the removed core tool-catalog files
## AI use
Select exactly one:
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex implemented the import cleanup, deletion, focused verification, and conflict analysis. The commit includes a `Generated-by: Codex` trailer.
## Checklist
- [ ] Tests cover the change and fail without it
- [ ] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [ ] Yes — described under Summary above
- [x] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] refactor(desktop): remove internal compatibility facades [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #4151:
URL: https://github.com/apache/maka/pull/4151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org