[GitHub] [incubator-mxnet] liuzh91 commented on a change in pull request #16982: Add support of plug and play fit_batch and evaluate_batch

[GitBox <gi...@apache.org>]

liuzh91 commented on a change in pull request #16982: Add support of plug and play fit_batch and evaluate_batch
URL: https://github.com/apache/incubator-mxnet/pull/16982#discussion_r354660279
 
 

 ##########
 File path: python/mxnet/gluon/contrib/estimator/estimator.py
 ##########
 @@ -269,9 +271,14 @@ def evaluate(self,
 
         for metric in val_metrics:
             metric.reset()
+        estimator_ref = self
 
         for _, batch in enumerate(val_data):
-            self.evaluate_batch(batch, val_metrics, batch_axis)
+            if self.estimator_model is None:
+                self.evaluate_batch(batch, val_metrics, batch_axis)
 
 Review comment:
   I think wrapping the `fit_batch` and `evaluate_batch` in one class is better. But I will brainstorm a better class name for the two methods. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services