You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/07/03 10:48:50 UTC

[Bug 120168] New: optimize chart saving to improve xls saving performance

https://issues.apache.org/ooo/show_bug.cgi?id=120168

          Priority: P3
            Bug ID: 120168
          Assignee: ooo-issues@incubator.apache.org
           Summary: optimize chart saving to improve xls saving
                    performance
          Severity: normal
        Issue Type: DEFECT
    Classification: Code
                OS: All
          Reporter: lizh.fee@gmail.com
          Hardware: All
            Status: UNCONFIRMED
           Version: AOO 3.4.0
         Component: www
           Product: performance

xls document with many oles(the chart) in it will cost much time when saving.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120168] optimize chart saving to improve xls saving performance

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120168

ChaoHuang <ch...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chao.dev.h@gmail.com

--- Comment #4 from ChaoHuang <ch...@gmail.com> ---
(In reply to comment #1)
> Root cause:
> All chart will be persisted as xml format on disk when xls saving, which is
> time consuming.
> 
> Resolution:
> If the chart has not been modified, then no need to update the persist files
> redundantly.

It should be better that if you can add the description of how to do UT for
this feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120168] optimize chart saving to improve xls saving performance

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120168

lizh.fee@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78597|                            |review?
              Flags|                            |

--- Comment #2 from lizh.fee@gmail.com ---
Created attachment 78597
  --> https://issues.apache.org/ooo/attachment.cgi?id=78597&action=edit
patch

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120168] optimize chart saving to improve xls saving performance

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120168

lizh.fee@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Issue Type|DEFECT                      |ENHANCEMENT

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120168] optimize chart saving to improve xls saving performance

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120168

--- Comment #6 from SVN Robot <sv...@dev.null.org> ---
"af" committed SVN revision 1359225: "#i120168# Do not call storeOwn() when not
necessary. "

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120168] optimize chart saving to improve xls saving performance

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120168

Andre <af...@a-w-f.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78598|review?                     |
              Flags|                            |

--- Comment #7 from Andre <af...@a-w-f.de> ---
Comment on attachment 78598
  --> https://issues.apache.org/ooo/attachment.cgi?id=78598
sample

Not a patch, no review necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120168] optimize chart saving to improve xls saving performance

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120168

Andre <af...@a-w-f.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |af@a-w-f.de
         Resolution|---                         |FIXED
           Assignee|ooo-issues@incubator.apache |af@a-w-f.de
                   |.org                        |

--- Comment #9 from Andre <af...@a-w-f.de> ---
Setting status to fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120168] optimize chart saving to improve xls saving performance

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120168

lizh.fee@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78598|                            |review?
              Flags|                            |

--- Comment #3 from lizh.fee@gmail.com ---
Created attachment 78598
  --> https://issues.apache.org/ooo/attachment.cgi?id=78598&action=edit
sample

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120168] optimize chart saving to improve xls saving performance

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120168

--- Comment #1 from lizh.fee@gmail.com ---
Root cause:
All chart will be persisted as xml format on disk when xls saving, which is
time consuming.

Resolution:
If the chart has not been modified, then no need to update the persist files
redundantly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120168] optimize chart saving to improve xls saving performance

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120168

--- Comment #5 from lizh.fee@gmail.com ---
steps for UT:

1. functiaonality aspect
open some .xls format document(with ole in it), modify the ole, then save, to
see whether the content is right or not.

open some .xls format document(with ole in it), modify some texts, then save,
to see whether the content is right or not.

2. performance aspect
open .xls document with many oles in it, do not modify ole or modify small
quantities of oles, then save, to see how much time cost by saving compared
with old version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120168] optimize chart saving to improve xls saving performance

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120168

Andre <af...@a-w-f.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78597|review?                     |review+
              Flags|                            |

--- Comment #8 from Andre <af...@a-w-f.de> ---
Comment on attachment 78597
  --> https://issues.apache.org/ooo/attachment.cgi?id=78597
patch

Reviewed and tested: OK

-- 
You are receiving this mail because:
You are the assignee for the bug.