You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/26 00:37:52 UTC

[GitHub] [superset] john-bodley commented on pull request #16318: feat(sqla): apply time grain to all temporal groupbys

john-bodley commented on pull request #16318:
URL: https://github.com/apache/superset/pull/16318#issuecomment-951450492


   @villebro this seems like a breaking change and thus should be behind a feature flag. 
   
   Note I understand the use case but it could be seen as a regression in terms of UX, i.e., it's not apparent to the user that the group-by temporal columns are also subject to the granularity which historically only applies to the temporal column. 
   
   An alternative approach—which requires more user work and isn't as dynamic—is to add custom columns which are granularity specific.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org