You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/07/30 21:32:23 UTC
[GitHub] [geode] demery-pivotal opened a new pull request #6731: GEODE-9483: Make StartLocatorCommandIntegrationTest not start unneeded locator
demery-pivotal opened a new pull request #6731:
URL: https://github.com/apache/geode/pull/6731
Two of the tests in `StartLocatorCommandIntegrationTest` launch a locator
process that binds to the default HTTP service port (7070). This can
interfere with the tests that explicitly verify that the system uses the
correct HTTP service port by default.
Neither test actually needs the launched locator for any purpose.
Neither test makes a single assertion about the locator. When the tests
exit, they leave the locator running. In fact, the locator typically
finishes launching well after the tests have all exited.
Rather than fix the port assignment, we should instead change the tests
so that they do not actually launch a locator. Two of the tests in this
class already do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] demery-pivotal commented on pull request #6731: GEODE-9483: Make StartLocatorCommandIntegrationTest not start unneeded locator
Posted by GitBox <gi...@apache.org>.
demery-pivotal commented on pull request #6731:
URL: https://github.com/apache/geode/pull/6731#issuecomment-896179472
The distributed test failure is unrelated to this PR. `RepeatedRebalanceDUnitTest.testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers` is known to fail intermittently: https://issues.apache.org/jira/browse/GEODE-7603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] demery-pivotal merged pull request #6731: GEODE-9483: Make StartLocatorCommandIntegrationTest not start unneeded locator
Posted by GitBox <gi...@apache.org>.
demery-pivotal merged pull request #6731:
URL: https://github.com/apache/geode/pull/6731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org