You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "john-bodley (via GitHub)" <gi...@apache.org> on 2024/01/03 00:24:08 UTC

Re: [PR] chore: Reenable SQLite tests which leverage foreign key constraints [superset]

john-bodley commented on code in PR #24605:
URL: https://github.com/apache/superset/pull/24605#discussion_r1439975705


##########
.github/workflows/superset-python-integrationtest.yml:
##########
@@ -150,7 +150,9 @@ jobs:
       SUPERSET_CONFIG: tests.integration_tests.superset_test_config
       REDIS_PORT: 16379
       SUPERSET__SQLALCHEMY_DATABASE_URI: |
-        sqlite:///${{ github.workspace }}/.temp/unittest.db

Review Comment:
   Weird name for a database used for integration tests. Calling this `superset.db` is inline with how the metadata database is used elsewhere.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org