[jira] [Comment Edited] (CALCITE-2847) Optimize global LOOKAHEAD for SQL parsers

["Kevin Risden (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790004#comment-16790004 ] 

Kevin Risden edited comment on CALCITE-2847 at 3/11/19 10:05 PM:
-----------------------------------------------------------------

Yea that is fine. Still trying to figure out the integration test failures on master. (email on dev list)

[~zhztheplayer] - pinged you on github, but can you squash the commits and rebase on current master. It looks like there were test failures on the PR.


was (Author: risdenk):
Yea that is fine. Still trying to figure out the integration test failures on master. (email on dev list)

[~zhztheplayer] - pinged you on JIRA, but can you squash the commits and rebase on current master. It looks like there were test failures on the PR.

> Optimize global LOOKAHEAD for SQL parsers
> -----------------------------------------
>
>                 Key: CALCITE-2847
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2847
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Hongze Zhang
>            Assignee: Hongze Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.19.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently global LOOKAHEAD is set to 2 for the built-in SQL parsers[1], we'd like to optimize LOOKAHEAD to 1 to enable performance enhancement if possible.
> [1]https://github.com/apache/calcite/blob/883666929478aabe07ee5b9e572c43a6f1a703e2/core/pom.xml#L304



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)