[GitHub] jerrypeng closed pull request #1881: [functions] Dont shade log4j2 in java runtime instance

[GitBox <gi...@apache.org>]

jerrypeng closed pull request #1881: [functions] Dont shade log4j2 in java runtime instance
URL: https://github.com/apache/incubator-pulsar/pull/1881
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pulsar-functions/runtime-all/pom.xml b/pulsar-functions/runtime-all/pom.xml
index 64e58e3c45..6c16916530 100644
--- a/pulsar-functions/runtime-all/pom.xml
+++ b/pulsar-functions/runtime-all/pom.xml
@@ -207,10 +207,12 @@
                   <pattern>jersey</pattern>
                   <shadedPattern>org.apache.pulsar.functions.runtime.shaded.jersey</shadedPattern>
                 </relocation>
+                <!-- DONT ever shade log4j, otherwise logging won't work anymore in running functions in process mode
                 <relocation>
                   <pattern>org.apache.logging</pattern>
                   <shadedPattern>org.apache.pulsar.functions.runtime.shaded.org.apache.logging</shadedPattern>
                 </relocation>
+                -->
                 <relocation>
                   <pattern>javassist</pattern>
                   <shadedPattern>org.apache.pulsar.functions.runtime.shaded.javassist</shadedPattern>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services