You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/09/11 00:25:17 UTC
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubnara@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18966
Change subject: IMPALA-10408: Support build using Apache components
......................................................................
IMPALA-10408: Support build using Apache components
Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M buildall.sh
M fe/pom.xml
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M java/TableFlattener/pom.xml
M java/executor-deps/pom.xml
9 files changed, 167 insertions(+), 52 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/18966/1
--
To view, visit http://gerrit.cloudera.org:8080/18966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e
Gerrit-Change-Number: 18966
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18966 )
Change subject: IMPALA-10408: Support build using Apache components
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/11332/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/18966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e
Gerrit-Change-Number: 18966
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 11 Sep 2022 00:29:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
eubnara@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18966 )
Change subject: IMPALA-10408: Support build using Apache components
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/18966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e
Gerrit-Change-Number: 18966
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
eubnara@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18966 )
Change subject: IMPALA-10408: Support build using Apache components
......................................................................
Abandoned
fix bug
--
To view, visit http://gerrit.cloudera.org:8080/18966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e
Gerrit-Change-Number: 18966
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
eubnara@gmail.com has restored this change. ( http://gerrit.cloudera.org:8080/18966 )
Change subject: IMPALA-10408: Support build using Apache components
......................................................................
Restored
--
To view, visit http://gerrit.cloudera.org:8080/18966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: restore
Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e
Gerrit-Change-Number: 18966
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18966 )
Change subject: IMPALA-10408: Support build using Apache components
......................................................................
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/18966/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/18966/1/bin/bootstrap_toolchain.py@519
PS1, Line 519: o
flake8: E501 line too long (140 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18966/1/bin/bootstrap_toolchain.py@524
PS1, Line 524: s
flake8: E501 line too long (171 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18966/1/bin/bootstrap_toolchain.py@539
PS1, Line 539: m
flake8: E501 line too long (130 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18966/1/bin/bootstrap_toolchain.py@544
PS1, Line 544: b
flake8: E501 line too long (132 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18966/1/bin/bootstrap_toolchain.py@605
PS1, Line 605: _
flake8: E501 line too long (123 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18966/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/18966/1/buildall.sh@415
PS1, Line 415: if [[ "${DOWNLOAD_CDH_COMPONENTS}" = true ]] || [[ "${DOWNLOAD_APACHE_COMPONENTS}" = true ]]; then
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/18966/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
File fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/18966/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@324
PS1, Line 324: req.setResource(new RangerAccessResourceImpl(Collections.unmodifiableMap(resource)));
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e
Gerrit-Change-Number: 18966
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 11 Sep 2022 00:26:18 +0000
Gerrit-HasComments: Yes