[GitHub] [geode] Bill commented on a change in pull request #5334: GEODE-8240: Back-Port to 1.12, Experimental

[GitBox <gi...@apache.org>]

Bill commented on a change in pull request #5334:
URL: https://github.com/apache/geode/pull/5334#discussion_r448446534



##########
File path: geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
##########
@@ -440,15 +441,21 @@ public boolean isPartial() {
   }
 
   @Override
-  public boolean equals(Object o) {
+  public boolean equals(final Object o) {
     if (this == o) {
       return true;
     }
-    if (o == null || getClass() != o.getClass()) {
+    if (o == null) {
+      return false;
+    }
+    if (o instanceof InternalDistributedMember) {
+      final InternalDistributedMember that = (InternalDistributedMember) o;
+      return memberIdentifier.equals(that.memberIdentifier);
+    } else if (o instanceof MemberIdentifier) {
+      return memberIdentifier.equals(o);
+    } else {

Review comment:
       this `equals()` method needed repair to get `GMSJoinLeaveJUnitTest` passing




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org