You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/06 03:24:29 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #8485:
[FLINK-12555] Introduce an encapsulated metric group layout for shuffle API
zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#discussion_r291008792
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -359,21 +359,14 @@ public Task(
final String taskNameWithSubtaskAndId = taskNameWithSubtask + " (" + executionId + ')';
- // add metrics for buffers
- final MetricGroup buffersGroup = metrics.getIOMetricGroup().addGroup("buffers");
-
- // similar to MetricUtils.instantiateNetworkMetrics() but inside this IOMetricGroup
- final MetricGroup networkGroup = metrics.getIOMetricGroup().addGroup("Network");
- final MetricGroup outputGroup = networkGroup.addGroup("Output");
- final MetricGroup inputGroup = networkGroup.addGroup("Input");
+ MetricGroup taskShuffleMetricGroup = networkEnvironment.createTaskMetricGroup(metrics.getIOMetricGroup());
Review comment:
Does it mean `ShuffleEnvironment` interface need provide the method `createTaskMetricGroup`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services