[GitHub] [calcite] vlsi commented on a change in pull request #2273: [CALCITE-4199] review-only: nullability annotations

[GitBox <gi...@apache.org>]

vlsi commented on a change in pull request #2273:
URL: https://github.com/apache/calcite/pull/2273#discussion_r528531071



##########
File path: core/src/main/java/org/apache/calcite/adapter/clone/ArrayTable.java
##########
@@ -243,9 +242,9 @@ public static List asList(final Representation representation,
 
     /** Converts a value set into a compact representation. If
      * {@code sources} is not null, permutes. */
-    Object freeze(ColumnLoader.ValueSet valueSet, int[] sources);
+    Object freeze(ColumnLoader.ValueSet valueSet, int @Nullable [] sources);

Review comment:
       Please read https://docs.oracle.com/javase/specs/jls/se8/html/jls-9.html#jls-9.7.4 amd 
   https://github.com/vlsi/calcite/blob/checkerframework/site/develop/index.md#null-safety
   
   `@Nullable int[]` and `int @Nullable []` are different.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org