You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alex Rudyy (Created) (JIRA)" <ji...@apache.org> on 2012/01/31 16:37:10 UTC

[jira] [Created] (QPID-3794) Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10

Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 
-----------------------------------------------------------------------------------------------------

                 Key: QPID-3794
                 URL: https://issues.apache.org/jira/browse/QPID-3794
             Project: Qpid
          Issue Type: Bug
          Components: Java Tests
    Affects Versions: 0.15
            Reporter: Alex Rudyy


Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 

junit.framework.AssertionFailedError: expected:<0.0> but was:<3000.0>
	at org.apache.qpid.server.stats.StatisticsCounterTest.testPeakOutOfOrder(StatisticsCounterTest.java:110)


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3794) Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10

Posted by "Alex Rudyy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy updated QPID-3794:
-----------------------------

    Status: Ready To Review  (was: In Progress)
    
> Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3794
>                 URL: https://issues.apache.org/jira/browse/QPID-3794
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Tests
>    Affects Versions: 0.15
>            Reporter: Alex Rudyy
>            Assignee: Alex Rudyy
>         Attachments: 0001-QPID-3794-fixes-ocasional-test-StatisticsCounterTest.patch
>
>
> Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 
> junit.framework.AssertionFailedError: expected:<0.0> but was:<3000.0>
> 	at org.apache.qpid.server.stats.StatisticsCounterTest.testPeakOutOfOrder(StatisticsCounterTest.java:110)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Resolved] (QPID-3794) Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10

Posted by "Robbie Gemmell (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell resolved QPID-3794.
----------------------------------

    Resolution: Fixed
    
> Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3794
>                 URL: https://issues.apache.org/jira/browse/QPID-3794
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Tests
>    Affects Versions: 0.15
>            Reporter: Alex Rudyy
>            Assignee: Robbie Gemmell
>         Attachments: 0001-QPID-3794-fixes-ocasional-test-StatisticsCounterTest.patch
>
>
> Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 
> junit.framework.AssertionFailedError: expected:<0.0> but was:<3000.0>
> 	at org.apache.qpid.server.stats.StatisticsCounterTest.testPeakOutOfOrder(StatisticsCounterTest.java:110)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3794) Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10

Posted by "Alex Rudyy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy updated QPID-3794:
-----------------------------

    Attachment: 0001-QPID-3794-fixes-ocasional-test-StatisticsCounterTest.patch

Attached a patch with a potential problem fix.

I could not reproduce the issue locally.

I believe that the only reason why this test failed is that the sequential invocations of Thread.sleep() caused current thread to sleep for more time than it was expected.

Thread.sleep(1500);
Thread.sleep(1000);

The total expected sleeping interval is 2500 mls.

It seems that for failed test the thread slept for more than 3000+ mls in total during first 2 sleep invocations and as result of it the counter peak value was evaluated due to finishing the sample period which is 1 second.

It seems that thread overslept for more than 500mls which is quite unexpected value. Perhaps, extra GC activity caused it. I am not sure.


                
> Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3794
>                 URL: https://issues.apache.org/jira/browse/QPID-3794
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Tests
>    Affects Versions: 0.15
>            Reporter: Alex Rudyy
>            Assignee: Alex Rudyy
>         Attachments: 0001-QPID-3794-fixes-ocasional-test-StatisticsCounterTest.patch
>
>
> Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 
> junit.framework.AssertionFailedError: expected:<0.0> but was:<3000.0>
> 	at org.apache.qpid.server.stats.StatisticsCounterTest.testPeakOutOfOrder(StatisticsCounterTest.java:110)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Assigned] (QPID-3794) Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10

Posted by "Alex Rudyy (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy reassigned QPID-3794:
--------------------------------

    Assignee: Robbie Gemmell  (was: Alex Rudyy)

Robbie,

Could you have a look at the patch attached?
                
> Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3794
>                 URL: https://issues.apache.org/jira/browse/QPID-3794
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Tests
>    Affects Versions: 0.15
>            Reporter: Alex Rudyy
>            Assignee: Robbie Gemmell
>         Attachments: 0001-QPID-3794-fixes-ocasional-test-StatisticsCounterTest.patch
>
>
> Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 
> junit.framework.AssertionFailedError: expected:<0.0> but was:<3000.0>
> 	at org.apache.qpid.server.stats.StatisticsCounterTest.testPeakOutOfOrder(StatisticsCounterTest.java:110)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Assigned] (QPID-3794) Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10

Posted by "Alex Rudyy (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy reassigned QPID-3794:
--------------------------------

    Assignee: Alex Rudyy
    
> Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3794
>                 URL: https://issues.apache.org/jira/browse/QPID-3794
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Tests
>    Affects Versions: 0.15
>            Reporter: Alex Rudyy
>            Assignee: Alex Rudyy
>
> Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 
> junit.framework.AssertionFailedError: expected:<0.0> but was:<3000.0>
> 	at org.apache.qpid.server.stats.StatisticsCounterTest.testPeakOutOfOrder(StatisticsCounterTest.java:110)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Commented] (QPID-3794) Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10

Posted by "Robbie Gemmell (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200467#comment-13200467 ] 

Robbie Gemmell commented on QPID-3794:
--------------------------------------

I have applied the patch, with a small update to ensure it doesnt result in negative values being used which will simply lead to a new failure mode. The patch looks like it should help, but it clearly wont be able to entirely fix the underlying issue leading to these sporadic failures; the tests highlights that they are pretty ugly and slightly indeterminate given their complete reliance on Thread.sleep() functionlity, so I have raised QPID-3811 to track future effort to make them more determinate (and faster!).
                
> Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3794
>                 URL: https://issues.apache.org/jira/browse/QPID-3794
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Tests
>    Affects Versions: 0.15
>            Reporter: Alex Rudyy
>            Assignee: Robbie Gemmell
>         Attachments: 0001-QPID-3794-fixes-ocasional-test-StatisticsCounterTest.patch
>
>
> Test StatisticsCounterTest.testPeakOutOfOrder fails sporadically on test profile java-mms-spawn.0-10 
> junit.framework.AssertionFailedError: expected:<0.0> but was:<3000.0>
> 	at org.apache.qpid.server.stats.StatisticsCounterTest.testPeakOutOfOrder(StatisticsCounterTest.java:110)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org