You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Shuaishuai Nie <sh...@microsoft.com> on 2013/05/08 02:30:47 UTC
Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter tests
to repo"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
This addresses bug SQOOP-1035.
https://issues.apache.org/jira/browse/SQOOP-1035
Diffs
-----
conf/MSTest.properties PRE-CREATION
src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
testdata/DatatypeTestData-export-lite.txt PRE-CREATION
testdata/DatatypeTestData-import-lite.txt PRE-CREATION
Diff: https://reviews.apache.org/r/10987/diff/
Testing
-------
All tests passing after applying the patch
Thanks,
Shuaishuai Nie
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review20456
-----------------------------------------------------------
Patch looks good except for a few nits. It is a big patch and adds lots of tests which is badly needed. There are few places where the editor generated TODO comments have to be removed and the exception handling can be a little bit more precise (instead of printing the stack trace and ignoring the exception), the exceptions can be rethrown after printing the stackTrace for debugging purposes if debug mode is enabled (you can check the logger)
Similar issues on test setup. If the setup throws an exception during one of the methods (say populate the table), it does not handle it - rethrow to abort the test. Similarly getConnection call ignores exception
Thanks
Venkat
src/test/com/cloudera/sqoop/hive/TestHiveImport.java
<https://reviews.apache.org/r/10987/#comment42139>
Nit - spaces
src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java
<https://reviews.apache.org/r/10987/#comment42140>
Can you please remove the comment - it has been implemented
src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java
<https://reviews.apache.org/r/10987/#comment42141>
please remove this
src/test/org/apache/sqoop/manager/MSSQLTestUtils.java
<https://reviews.apache.org/r/10987/#comment42142>
Please remove this. Don't we want to return null in this case?
src/test/org/apache/sqoop/manager/MSSQLTestUtils.java
<https://reviews.apache.org/r/10987/#comment42143>
Please remove this exception block. As the method is throwing the SQLException, it should be OK and the caller can handle the exception
src/test/org/apache/sqoop/manager/MSSQLTestUtils.java
<https://reviews.apache.org/r/10987/#comment42144>
Please remove this block or rethrow the exception
src/test/org/apache/sqoop/manager/MSSQLTestUtils.java
<https://reviews.apache.org/r/10987/#comment42145>
Same as before. There are too many of these in the files, can you please address all of them.
- Venkat Ranganathan
On May 8, 2013, 12:30 a.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated May 8, 2013, 12:30 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> conf/MSTest.properties PRE-CREATION
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
> src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
> src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21805
-----------------------------------------------------------
Ship it!
Thanks for addressing the comments. I could successfully apply it. We can still make some of the enhancements I wrote in an earlier review, but those can definitely follow in a follow-on JIRA.
- Venkat Ranganathan
On June 12, 2013, 5:30 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 5:30 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> src/test/com/cloudera/sqoop/ThirdPartyTests.java 7e361d2
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 9c47bad
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
> testdata/MSTest.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Shuaishuai Nie <sh...@microsoft.com>.
> On June 18, 2013, 10:09 p.m., Jarek Cecho wrote:
> > Hi Shuaishuai,
> > thank you very much for incorporating all the suggestions and notes, greatly appreciated. Please upload the latest patch to the JIRA and I'll commit this!
> >
> > Jarcec
Thanks Jarec. Attached the patch to JIRA.
- Shuaishuai
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review22076
-----------------------------------------------------------
On June 18, 2013, 8:57 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 8:57 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> build.xml ffc878e
> src/test/com/cloudera/sqoop/ThirdPartyTests.java 7b1fa26
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 9c47bad
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review22076
-----------------------------------------------------------
Ship it!
Hi Shuaishuai,
thank you very much for incorporating all the suggestions and notes, greatly appreciated. Please upload the latest patch to the JIRA and I'll commit this!
Jarcec
- Jarek Cecho
On June 18, 2013, 8:57 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 8:57 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> build.xml ffc878e
> src/test/com/cloudera/sqoop/ThirdPartyTests.java 7b1fa26
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 9c47bad
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Shuaishuai Nie <sh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/
-----------------------------------------------------------
(Updated June 18, 2013, 8:57 p.m.)
Review request for Sqoop.
Description
-------
Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
This addresses bug SQOOP-1035.
https://issues.apache.org/jira/browse/SQOOP-1035
Diffs (updated)
-----
build.xml ffc878e
src/test/com/cloudera/sqoop/ThirdPartyTests.java 7b1fa26
src/test/com/cloudera/sqoop/hive/TestHiveImport.java 9c47bad
src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestData.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestDataFileParser.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/ManagerCompatExport.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerHiveImportManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiColsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiMapsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerParseMethodsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerQueryManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerSplitByManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerWhereManualTest.java PRE-CREATION
testdata/DatatypeTestData-export-lite.txt PRE-CREATION
testdata/DatatypeTestData-import-lite.txt PRE-CREATION
Diff: https://reviews.apache.org/r/10987/diff/
Testing
-------
All tests passing after applying the patch
Thanks,
Shuaishuai Nie
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Shuaishuai Nie <sh...@microsoft.com>.
> On June 15, 2013, 5:41 p.m., Jarek Cecho wrote:
> > src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java, lines 208-209
> > <https://reviews.apache.org/r/10987/diff/6/?file=304180#file304180line208>
> >
> > The SQOOP_HOME variable is not defined by default when running tests. I would advise to use some test specific java property, there is many of them already defined or we can define new one if needed
> >
> > The test properties are created in the build.xml file here:
> >
> > https://github.com/apache/sqoop/blob/branch-1.4.0/build.xml#L596
Create "test.data.dir" system property in build.xml to point to the folder which contain the test data
> On June 15, 2013, 5:41 p.m., Jarek Cecho wrote:
> > testdata/MSTest.properties, lines 1-40
> > <https://reviews.apache.org/r/10987/diff/6/?file=304196#file304196line1>
> >
> > The usual workflow on jenkins is to check out the repository and set all required variables and/or properties for running the tests. It's completely fine to store defaults into file, however we have to be able to override all properties during ant execution, e.g something like:
> >
> > ant clean test -Dms.db.server.name=new_host
> >
> > It seems to me that this is not possible with current infrastructure, right? I'm afraid that changing checkout file is not feasible.
remove MSTest.properties file and define ms.sqlserver.username and ms.sqlserver.password in build.xml which can be passed as through ant command. Also since the servername is contained in "sqoop.test.sqlserver.connectstring.host_url", it can also passed through command line.
"ant test -Dmanual=true "-Dsqoop.test.sqlserver.connectstring.host_url=jdbc:sqlserver://MYSERVERNAME" "-Dms.sqlserver.username=MYUSERNAME" "-Dms.sqlserver.password=MYPASSWORD"" command like this should be able to run sqlserver test in jenkins
> On June 15, 2013, 5:41 p.m., Jarek Cecho wrote:
> > testdata/MSTest.properties, line 22
> > <https://reviews.apache.org/r/10987/diff/6/?file=304196#file304196line22>
> >
> > Is there a reason why are not reusing the property sqoop.test.sqlserver.connectstring.host_url that is already used in existing SQL Server tests? I would prefer to have one single property for all tests for one single db vendor.
Sorry missed it in the last patch. Fixed in the latest version
- Shuaishuai
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21940
-----------------------------------------------------------
On June 18, 2013, 8:57 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 8:57 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> build.xml ffc878e
> src/test/com/cloudera/sqoop/ThirdPartyTests.java 7b1fa26
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 9c47bad
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21940
-----------------------------------------------------------
Hi Shuaishuai,
I was able to run the tests in my environment and the changes looks good. I do have just couple of nitpicky comments:
src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java
<https://reviews.apache.org/r/10987/#comment45239>
The SQOOP_HOME variable is not defined by default when running tests. I would advise to use some test specific java property, there is many of them already defined or we can define new one if needed
The test properties are created in the build.xml file here:
https://github.com/apache/sqoop/blob/branch-1.4.0/build.xml#L596
src/test/org/apache/sqoop/manager/sqlserver/ManagerCompatExport.java
<https://reviews.apache.org/r/10987/#comment45241>
Similar as above, depending on SQOOP_HOME during test execution is not necessary.
testdata/MSTest.properties
<https://reviews.apache.org/r/10987/#comment45240>
The usual workflow on jenkins is to check out the repository and set all required variables and/or properties for running the tests. It's completely fine to store defaults into file, however we have to be able to override all properties during ant execution, e.g something like:
ant clean test -Dms.db.server.name=new_host
It seems to me that this is not possible with current infrastructure, right? I'm afraid that changing checkout file is not feasible.
testdata/MSTest.properties
<https://reviews.apache.org/r/10987/#comment45242>
Is there a reason why are not reusing the property sqoop.test.sqlserver.connectstring.host_url that is already used in existing SQL Server tests? I would prefer to have one single property for all tests for one single db vendor.
Jarcec
- Jarek Cecho
On June 12, 2013, 5:30 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 5:30 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> src/test/com/cloudera/sqoop/ThirdPartyTests.java 7e361d2
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 9c47bad
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
> testdata/MSTest.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Shuaishuai Nie <sh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/
-----------------------------------------------------------
(Updated June 12, 2013, 5:30 p.m.)
Review request for Sqoop.
Description
-------
Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
This addresses bug SQOOP-1035.
https://issues.apache.org/jira/browse/SQOOP-1035
Diffs (updated)
-----
src/test/com/cloudera/sqoop/ThirdPartyTests.java 7e361d2
src/test/com/cloudera/sqoop/hive/TestHiveImport.java 9c47bad
src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestData.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestDataFileParser.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/ManagerCompatExport.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerHiveImportManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiColsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiMapsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerParseMethodsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerQueryManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerSplitByManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/sqlserver/SQLServerWhereManualTest.java PRE-CREATION
testdata/DatatypeTestData-export-lite.txt PRE-CREATION
testdata/DatatypeTestData-import-lite.txt PRE-CREATION
testdata/MSTest.properties PRE-CREATION
Diff: https://reviews.apache.org/r/10987/diff/
Testing
-------
All tests passing after applying the patch
Thanks,
Shuaishuai Nie
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Shuaishuai Nie <sh...@microsoft.com>.
> On June 3, 2013, 10:36 a.m., Abhijeet Gaikwad wrote:
> > conf/MSTest.properties, line 1
> > <https://reviews.apache.org/r/10987/diff/5/?file=295730#file295730line1>
> >
> > Some unused properties in this file.
removed unused properties in the file
> On June 3, 2013, 10:36 a.m., Abhijeet Gaikwad wrote:
> > src/test/org/apache/sqoop/manager/MSSQLTestUtils.java, line 46
> > <https://reviews.apache.org/r/10987/diff/5/?file=295735#file295735line46>
> >
> > We can remove these privates.
removed from code
- Shuaishuai
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21310
-----------------------------------------------------------
On May 23, 2013, 5:55 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 5:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> conf/MSTest.properties PRE-CREATION
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
> src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
> src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Jarek Cecho <ja...@apache.org>.
> On June 3, 2013, 10:36 a.m., Abhijeet Gaikwad wrote:
> > Huge patch, thanks for the contribution!
> > I see some unrelated code in the patch. Let me know if you need any help cleaning that up.
> >
> > I am yet to review the patch thoroughly, but it may take time. I would be more than happy if anyone else reviews and commits this before. Thanks!
Yup, I'll take a look as well.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21310
-----------------------------------------------------------
On May 23, 2013, 5:55 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 5:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> conf/MSTest.properties PRE-CREATION
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
> src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
> src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Abhijeet Gaikwad <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21310
-----------------------------------------------------------
Huge patch, thanks for the contribution!
I see some unrelated code in the patch. Let me know if you need any help cleaning that up.
I am yet to review the patch thoroughly, but it may take time. I would be more than happy if anyone else reviews and commits this before. Thanks!
conf/MSTest.properties
<https://reviews.apache.org/r/10987/#comment44207>
Some unused properties in this file.
src/test/org/apache/sqoop/manager/MSSQLTestUtils.java
<https://reviews.apache.org/r/10987/#comment44208>
We can remove these privates.
- Abhijeet Gaikwad
On May 23, 2013, 5:55 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 5:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> conf/MSTest.properties PRE-CREATION
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
> src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
> src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21042
-----------------------------------------------------------
Ship it!
I successfully got it compiled and ran the unit tests to make sure nothing was broken. Still there are a few places where logger is not properly used. Many cases of System.out can be factored like that. Also, constructs like this
LOG.error("Setup fail with SQLException: " + StringUtils.stringifyException(e));
Can be simply
LOG.error("Setup failed", e);
Unless there is a specific reason.
These things can be addressed in a follow on JIRA I feel as this changeset is big.
- Venkat Ranganathan
On May 23, 2013, 5:55 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 5:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> conf/MSTest.properties PRE-CREATION
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
> src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
> src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Shuaishuai Nie <sh...@microsoft.com>.
> On June 9, 2013, 4:23 p.m., Jarek Cecho wrote:
> > src/test/org/apache/sqoop/manager/MSSQLTestUtils.java, lines 46-63
> > <https://reviews.apache.org/r/10987/diff/5/?file=295735#file295735line46>
> >
> > Is there a linux equivalent for these commands?
This is no longer necessary for the integration test, so removed from the code
> On June 9, 2013, 4:23 p.m., Jarek Cecho wrote:
> > conf/MSTest.properties, lines 1-5
> > <https://reviews.apache.org/r/10987/diff/5/?file=295730#file295730line1>
> >
> > The top level conf/ directory should be used only for code that is mean to be used for the actual product, not for the tests. Would it be feasible to move it somewhere else? For example to testdata/ or src/test?
> >
> > Also this file is missing Apache License.
moved to SQOOP_HOME/testdata/
> On June 9, 2013, 4:23 p.m., Jarek Cecho wrote:
> > testdata/DatatypeTestData-export-lite.txt, line 1
> > <https://reviews.apache.org/r/10987/diff/5/?file=295749#file295749line1>
> >
> > This file do not have a license. We need to either put a license here or configure RAT to skip checking this file.
It seems the /testdata/ folder is excluded by rat in /src/scripts/rat-violation.sh already
> On June 9, 2013, 4:23 p.m., Jarek Cecho wrote:
> > testdata/DatatypeTestData-import-lite.txt, line 1
> > <https://reviews.apache.org/r/10987/diff/5/?file=295750#file295750line1>
> >
> > This file do not have a license. We need to either put a license here or configure RAT to skip checking this file.
It seems the /testdata/ folder is excluded by rat in /src/scripts/rat-violation.sh already
- Shuaishuai
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21151
-----------------------------------------------------------
On May 23, 2013, 5:55 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 5:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> conf/MSTest.properties PRE-CREATION
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
> src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
> src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21151
-----------------------------------------------------------
Hi Shuaishuai,
thank you for this significant effort! I do have couple of high level comments:
1) Thank you for putting the new tests into new "manager" package. Do you think that it would make sense to go even further and put the MS SQL specific tests into "manager/sqlserver" package? I'm assuming that we will add more tests for other connectors in the future as well, so this might help to have the packages clean.
2) Can you register all the new tests in ThirdParty test suite? (https://github.com/apache/sqoop/blob/trunk/src/test/com/cloudera/sqoop/ThirdPartyTests.java) I know that existing SQL Server tests are not there, but I believe that they should.
conf/MSTest.properties
<https://reviews.apache.org/r/10987/#comment43920>
The top level conf/ directory should be used only for code that is mean to be used for the actual product, not for the tests. Would it be feasible to move it somewhere else? For example to testdata/ or src/test?
Also this file is missing Apache License.
conf/MSTest.properties
<https://reviews.apache.org/r/10987/#comment44700>
Rest of the project is using lowercased properties separating logical parts using dot. For example JDBC URL is in existing SQLServerManagerImportManualTest specified via following property:
sqoop.test.sqlserver.connectstring.host_url
I think that it would make sense to stay consistent. Also I would suggest to reuse properties that are already used, such the connection string above.
conf/MSTest.properties
<https://reviews.apache.org/r/10987/#comment44696>
Sqoop is primary supported on linux, so please change all defaults from Windows domains to a linux paths. Also I would strongly advise to use relative paths rather then absolute ones.
src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java
<https://reviews.apache.org/r/10987/#comment44697>
Nit: Is this isolated change necessary?
src/test/org/apache/sqoop/manager/MSSQLTestData.java
<https://reviews.apache.org/r/10987/#comment43921>
Can we add javadoc explaining purpose of this class?
src/test/org/apache/sqoop/manager/MSSQLTestData.java
<https://reviews.apache.org/r/10987/#comment44698>
Can we add comments explaining the enum constants with their purpose?
src/test/org/apache/sqoop/manager/MSSQLTestData.java
<https://reviews.apache.org/r/10987/#comment44699>
Nit: Is the main method artifact from previous development?
src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java
<https://reviews.apache.org/r/10987/#comment43922>
Nit: This seems to artifact from development.
src/test/org/apache/sqoop/manager/MSSQLTestUtils.java
<https://reviews.apache.org/r/10987/#comment43923>
Is there a linux equivalent for these commands?
src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java
<https://reviews.apache.org/r/10987/#comment43924>
Nit: Indentation seems to be off here.
testdata/DatatypeTestData-export-lite.txt
<https://reviews.apache.org/r/10987/#comment43925>
This file do not have a license. We need to either put a license here or configure RAT to skip checking this file.
testdata/DatatypeTestData-import-lite.txt
<https://reviews.apache.org/r/10987/#comment43926>
This file do not have a license. We need to either put a license here or configure RAT to skip checking this file.
Jarcec
- Jarek Cecho
On May 23, 2013, 5:55 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 5:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> conf/MSTest.properties PRE-CREATION
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
> src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
> src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Shuaishuai Nie <sh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/
-----------------------------------------------------------
(Updated May 23, 2013, 5:55 p.m.)
Review request for Sqoop.
Changes
-------
Enhance Logging and setup() of ManagerCompatExport
Description
-------
Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
This addresses bug SQOOP-1035.
https://issues.apache.org/jira/browse/SQOOP-1035
Diffs (updated)
-----
conf/MSTest.properties PRE-CREATION
src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
testdata/DatatypeTestData-export-lite.txt PRE-CREATION
testdata/DatatypeTestData-import-lite.txt PRE-CREATION
Diff: https://reviews.apache.org/r/10987/diff/
Testing
-------
All tests passing after applying the patch
Thanks,
Shuaishuai Nie
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review20855
-----------------------------------------------------------
Almost ready! Thanks for the update. I think it would be good to use the logger to log the messages and stack traces (should be under debug level). I have not marked all occurrences but I think you get the idea.
Thanks
Venkat
src/test/org/apache/sqoop/manager/ManagerCompatExport.java
<https://reviews.apache.org/r/10987/#comment42962>
Can this be done as part of setUP?
src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java
<https://reviews.apache.org/r/10987/#comment42963>
I think it would be good to push all the printStackTrace under LOG.debug and use the logger to capture the stacktrace. You can provide a stringified stack trace if you think the logger is truncating your stack trace.
- Venkat Ranganathan
On May 16, 2013, 6:48 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated May 16, 2013, 6:48 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> conf/MSTest.properties PRE-CREATION
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
> src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
> src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Shuaishuai Nie <sh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/
-----------------------------------------------------------
(Updated May 16, 2013, 6:48 p.m.)
Review request for Sqoop.
Changes
-------
add test data which is missing in the former diff
Description
-------
Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
This addresses bug SQOOP-1035.
https://issues.apache.org/jira/browse/SQOOP-1035
Diffs (updated)
-----
conf/MSTest.properties PRE-CREATION
src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
testdata/DatatypeTestData-export-lite.txt PRE-CREATION
testdata/DatatypeTestData-import-lite.txt PRE-CREATION
Diff: https://reviews.apache.org/r/10987/diff/
Testing
-------
All tests passing after applying the patch
Thanks,
Shuaishuai Nie
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Shuaishuai Nie <sh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/
-----------------------------------------------------------
(Updated May 14, 2013, 12:31 a.m.)
Review request for Sqoop.
Changes
-------
Update exception handling during setup and teardown of the tests
Description
-------
Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
This addresses bug SQOOP-1035.
https://issues.apache.org/jira/browse/SQOOP-1035
Diffs (updated)
-----
conf/MSTest.properties PRE-CREATION
src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/10987/diff/
Testing
-------
All tests passing after applying the patch
Thanks,
Shuaishuai Nie
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Shuaishuai Nie <sh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/
-----------------------------------------------------------
(Updated May 13, 2013, 8:54 p.m.)
Review request for Sqoop.
Changes
-------
Fix the format and remove extra comments
Description
-------
Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
This addresses bug SQOOP-1035.
https://issues.apache.org/jira/browse/SQOOP-1035
Diffs (updated)
-----
conf/MSTest.properties PRE-CREATION
src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/10987/diff/
Testing
-------
All tests passing after applying the patch
Thanks,
Shuaishuai Nie