You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/04 22:08:56 UTC
[GitHub] [hudi] xushiyan opened a new pull request, #6040: [WIP][HUDI-4322] Deprecate partition value extractor
xushiyan opened a new pull request, #6040:
URL: https://github.com/apache/hudi/pull/6040
Users do not need to set partition value extractor for meta sync. The existing interface `PartitionValueExtractor` is marked as deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6040: [HUDI-4322] Deprecate partition value extractor
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6040:
URL: https://github.com/apache/hudi/pull/6040#issuecomment-1179818457
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9822",
"triggerID" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"triggerType" : "PUSH"
}, {
"hash" : "1b4cc6bec021b6278c98847ca2cc36123b737eb9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9825",
"triggerID" : "1b4cc6bec021b6278c98847ca2cc36123b737eb9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b4cc6bec021b6278c98847ca2cc36123b737eb9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9825)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6040: [HUDI-4322] Deprecate partition value extractor
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6040:
URL: https://github.com/apache/hudi/pull/6040#issuecomment-1179989127
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9822",
"triggerID" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"triggerType" : "PUSH"
}, {
"hash" : "1b4cc6bec021b6278c98847ca2cc36123b737eb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9825",
"triggerID" : "1b4cc6bec021b6278c98847ca2cc36123b737eb9",
"triggerType" : "PUSH"
}, {
"hash" : "81889af3bd79b4c674223e8155710866eef7b305",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9828",
"triggerID" : "81889af3bd79b4c674223e8155710866eef7b305",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 81889af3bd79b4c674223e8155710866eef7b305 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9828)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6040: [HUDI-4322] Deprecate partition value extractor
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6040:
URL: https://github.com/apache/hudi/pull/6040#issuecomment-1179808449
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9822",
"triggerID" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"triggerType" : "PUSH"
}, {
"hash" : "1b4cc6bec021b6278c98847ca2cc36123b737eb9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1b4cc6bec021b6278c98847ca2cc36123b737eb9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 15209b8aad0e58b3d630564463f7c0f4de23a58a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9822)
* 1b4cc6bec021b6278c98847ca2cc36123b737eb9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #6040: [HUDI-4322] Deprecate partition value extractor
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #6040:
URL: https://github.com/apache/hudi/pull/6040#discussion_r917454294
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieConfig.java:
##########
@@ -187,15 +204,6 @@ public <T> Double getDouble(ConfigProperty<T> configProperty) {
return rawValue.map(v -> Double.parseDouble(v.toString())).orElse(null);
}
- public <T> String getStringOrDefault(ConfigProperty<T> configProperty) {
- return getStringOrDefault(configProperty, configProperty.defaultValue().toString());
- }
-
- public <T> String getStringOrDefault(ConfigProperty<T> configProperty, String defaultVal) {
- Option<Object> rawValue = getRawValue(configProperty);
- return rawValue.map(Object::toString).orElse(defaultVal);
- }
Review Comment:
re-arranged `getString*()` methods to keep them close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6040: [HUDI-4322] Deprecate partition value extractor
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6040:
URL: https://github.com/apache/hudi/pull/6040#issuecomment-1179778886
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9822",
"triggerID" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 15209b8aad0e58b3d630564463f7c0f4de23a58a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9822)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan closed pull request #6040: [HUDI-4322] Deprecate partition value extractor
Posted by GitBox <gi...@apache.org>.
xushiyan closed pull request #6040: [HUDI-4322] Deprecate partition value extractor
URL: https://github.com/apache/hudi/pull/6040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6040: [HUDI-4322] Deprecate partition value extractor
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6040:
URL: https://github.com/apache/hudi/pull/6040#issuecomment-1179770249
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 15209b8aad0e58b3d630564463f7c0f4de23a58a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6040: [HUDI-4322] Deprecate partition value extractor
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6040:
URL: https://github.com/apache/hudi/pull/6040#issuecomment-1179809089
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9822",
"triggerID" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"triggerType" : "PUSH"
}, {
"hash" : "1b4cc6bec021b6278c98847ca2cc36123b737eb9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9825",
"triggerID" : "1b4cc6bec021b6278c98847ca2cc36123b737eb9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 15209b8aad0e58b3d630564463f7c0f4de23a58a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9822)
* 1b4cc6bec021b6278c98847ca2cc36123b737eb9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9825)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6040: [HUDI-4322] Deprecate partition value extractor
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6040:
URL: https://github.com/apache/hudi/pull/6040#issuecomment-1179770820
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9822",
"triggerID" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 15209b8aad0e58b3d630564463f7c0f4de23a58a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9822)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6040: [HUDI-4322] Deprecate partition value extractor
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6040:
URL: https://github.com/apache/hudi/pull/6040#issuecomment-1179931579
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9822",
"triggerID" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"triggerType" : "PUSH"
}, {
"hash" : "1b4cc6bec021b6278c98847ca2cc36123b737eb9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9825",
"triggerID" : "1b4cc6bec021b6278c98847ca2cc36123b737eb9",
"triggerType" : "PUSH"
}, {
"hash" : "81889af3bd79b4c674223e8155710866eef7b305",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9828",
"triggerID" : "81889af3bd79b4c674223e8155710866eef7b305",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b4cc6bec021b6278c98847ca2cc36123b737eb9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9825)
* 81889af3bd79b4c674223e8155710866eef7b305 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9828)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6040: [HUDI-4322] Deprecate partition value extractor
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6040:
URL: https://github.com/apache/hudi/pull/6040#issuecomment-1179929830
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9822",
"triggerID" : "15209b8aad0e58b3d630564463f7c0f4de23a58a",
"triggerType" : "PUSH"
}, {
"hash" : "1b4cc6bec021b6278c98847ca2cc36123b737eb9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9825",
"triggerID" : "1b4cc6bec021b6278c98847ca2cc36123b737eb9",
"triggerType" : "PUSH"
}, {
"hash" : "81889af3bd79b4c674223e8155710866eef7b305",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "81889af3bd79b4c674223e8155710866eef7b305",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b4cc6bec021b6278c98847ca2cc36123b737eb9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9825)
* 81889af3bd79b4c674223e8155710866eef7b305 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org