You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/23 05:33:20 UTC
[GitHub] [shardingsphere] TeslaCN opened a new pull request, #23053: Refactor MySQL sequence ID handling logic
TeslaCN opened a new pull request, #23053:
URL: https://github.com/apache/shardingsphere/pull/23053
Fixes #20713.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23053: Refactor MySQL sequence ID handling logic
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23053:
URL: https://github.com/apache/shardingsphere/pull/23053#issuecomment-1363658718
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23053?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23053](https://codecov.io/gh/apache/shardingsphere/pull/23053?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75f19cd) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6e5f96442aeee6ced1c98a2cd3317fc61fd1450d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e5f964) will **increase** coverage by `0.00%`.
> The diff coverage is `82.60%`.
```diff
@@ Coverage Diff @@
## master #23053 +/- ##
=========================================
Coverage 50.05% 50.06%
+ Complexity 2428 2424 -4
=========================================
Files 4110 4110
Lines 57341 57325 -16
Branches 9041 9038 -3
=========================================
- Hits 28704 28697 -7
+ Misses 26130 26122 -8
+ Partials 2507 2506 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23053?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ol/mysql/packet/binlog/MySQLBinlogEventHeader.java](https://codecov.io/gh/apache/shardingsphere/pull/23053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvTXlTUUxCaW5sb2dFdmVudEhlYWRlci5qYXZh) | `94.11% <ø> (-0.33%)` | :arrow_down: |
| [...tocol/mysql/packet/command/MySQLCommandPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/23053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL015U1FMQ29tbWFuZFBhY2tldC5qYXZh) | `80.00% <ø> (-3.34%)` | :arrow_down: |
| [...l/packet/command/MySQLCommandPacketTypeLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL015U1FMQ29tbWFuZFBhY2tldFR5cGVMb2FkZXIuamF2YQ==) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [.../binary/execute/MySQLBinaryResultSetRowPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/23053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L2JpbmFyeS9leGVjdXRlL015U1FMQmluYXJ5UmVzdWx0U2V0Um93UGFja2V0LmphdmE=) | `95.45% <ø> (ø)` | |
| [...ry/binary/prepare/MySQLComStmtPrepareOKPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/23053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L2JpbmFyeS9wcmVwYXJlL015U1FMQ29tU3RtdFByZXBhcmVPS1BhY2tldC5qYXZh) | `87.50% <ø> (ø)` | |
| [...ommand/query/text/MySQLTextResultSetRowPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/23053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L3RleHQvTXlTUUxUZXh0UmVzdWx0U2V0Um93UGFja2V0LmphdmE=) | `86.95% <ø> (-0.55%)` | :arrow_down: |
| [...ysql/packet/handshake/MySQLAuthMoreDataPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/23053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxBdXRoTW9yZURhdGFQYWNrZXQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...packet/handshake/MySQLAuthSwitchRequestPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/23053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxBdXRoU3dpdGNoUmVxdWVzdFBhY2tldC5qYXZh) | `33.33% <ø> (+2.56%)` | :arrow_up: |
| [...acket/handshake/MySQLAuthSwitchResponsePacket.java](https://codecov.io/gh/apache/shardingsphere/pull/23053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxBdXRoU3dpdGNoUmVzcG9uc2VQYWNrZXQuamF2YQ==) | `50.00% <ø> (-7.15%)` | :arrow_down: |
| [...l/mysql/packet/handshake/MySQLHandshakePacket.java](https://codecov.io/gh/apache/shardingsphere/pull/23053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxIYW5kc2hha2VQYWNrZXQuamF2YQ==) | `82.69% <ø> (+1.21%)` | :arrow_up: |
| ... and [32 more](https://codecov.io/gh/apache/shardingsphere/pull/23053/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #23053: Refactor MySQL sequence ID handling logic
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #23053:
URL: https://github.com/apache/shardingsphere/pull/23053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org