[GitHub] [accumulo] dlmarion commented on a diff in pull request #2764: Fix Reference in TabletGroupWatcher

[GitBox <gi...@apache.org>]

dlmarion commented on code in PR #2764:
URL: https://github.com/apache/accumulo/pull/2764#discussion_r894405030


##########
core/src/main/java/org/apache/accumulo/core/gc/Reference.java:
##########
@@ -36,7 +35,6 @@ public Reference(TableId tableId, String metadataEntry) {
     MetadataSchema.TabletsSection.ServerColumnFamily.validateDirCol(tableId.canonical());
     this.tableId = tableId;
     this.metadataEntry = metadataEntry;
-    this.tabletDir = metadataEntry;
   }

Review Comment:
   Is there a way to determine if this references a directory? It would be good to have a `isDirectory()` method in this class and then one in `ReferenceDirectory` that overrides it and returns true. In fact, you may be able to remove `ReferenceDirectory` if you have the ability to determine if the metadata entry is a directory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org