You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/26 19:51:55 UTC
[GitHub] [arrow-datafusion] nvartolomei opened a new pull request, #3276: Return from task execution if send fails as there is nothing more to do
nvartolomei opened a new pull request, #3276:
URL: https://github.com/apache/arrow-datafusion/pull/3276
This doesn't introduce much change in behaviour as the tasks were shut down (usually) by `AbortOnDropMany` anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3276: Return from task execution if send fails as there is nothing more to do
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3276:
URL: https://github.com/apache/arrow-datafusion/pull/3276#issuecomment-1236091521
Thanks @nvartolomei -- this looks like a very nice improvement so I will merge it in and add a log message as a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #3276: Return from task execution if send fails as there is nothing more to do
Posted by GitBox <gi...@apache.org>.
alamb merged PR #3276:
URL: https://github.com/apache/arrow-datafusion/pull/3276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3276: Return from task execution if send fails as there is nothing more to do (faster cancel / limit)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3276:
URL: https://github.com/apache/arrow-datafusion/pull/3276#issuecomment-1236092032
Benchmark runs are scheduled for baseline = 93a95c25fd04100185f6e7dd735635eaa7d5613e and contender = 7a53872d106e0c749a1ec848dcac6fe086a8eb21. 7a53872d106e0c749a1ec848dcac6fe086a8eb21 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b682362603a74190b8d82ef26aed169a...d7c1290c34e44ccea2db5e45b3f3a43c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/31b92ef182364e98abf6a916e143be1e...ba79625185de450ca7e192c65b062062/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/0d5ca7c815834e77b4d7fc5389eab9b7...ae0de782e9e341628ab97de611370e2d/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/7bfb50755fb54a1f8ae1eaeb5b0b1393...3f73306c8d2d4899ae48673852925bf8/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3276: Return from task execution if send fails as there is nothing more to do
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #3276:
URL: https://github.com/apache/arrow-datafusion/pull/3276#discussion_r956403122
##########
datafusion/core/src/physical_plan/common.rs:
##########
@@ -192,8 +192,10 @@ pub(crate) fn spawn_execution(
while let Some(item) = stream.next().await {
// If send fails, plan being torn down,
- // there is no place to send the error
- output.send(item).await.ok();
+ // there is no place to send the error.
+ if let Err(_) = output.send(item).await {
+ return;
Review Comment:
The change looks reasonable, but I think we should at least log a debug or warning message rather than silently consuming the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3276: Return from task execution if send fails as there is nothing more to do (faster cancel / limit)
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3276:
URL: https://github.com/apache/arrow-datafusion/pull/3276#discussion_r962135373
##########
datafusion/core/src/physical_plan/common.rs:
##########
@@ -192,8 +192,10 @@ pub(crate) fn spawn_execution(
while let Some(item) = stream.next().await {
// If send fails, plan being torn down,
- // there is no place to send the error
- output.send(item).await.ok();
+ // there is no place to send the error.
+ if let Err(_) = output.send(item).await {
+ return;
Review Comment:
in https://github.com/apache/arrow-datafusion/pull/3350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org