You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org> on 2022/03/04 13:36:32 UTC

[Impala-ASF-CR] IMPALA-10946: Replaced URLDecoder with Hive's unescape

Gergely Fürnstáhl has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18274 )

Change subject: IMPALA-10946: Replaced URLDecoder with Hive's unescape
......................................................................

IMPALA-10946: Replaced URLDecoder with Hive's unescape

Hive is using an own implementation of escaping and unescaping partition
pathes, which is similar to URL decoding, but not the same, for example
it does not escape '+'.

Modified Impala to use the same unescaping algorithm to prevent creating
phantom partitions in HMS.

Testing:

The reproduction in the Jira is fixed, "abc " is no longer created.

Change-Id: Ie821a0795d99eb9aa95131323917c9a3d0e8e1ec
---
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/18274/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie821a0795d99eb9aa95131323917c9a3d0e8e1ec
Gerrit-Change-Number: 18274
Gerrit-PatchSet: 5
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>