You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Thiruvel Thirumoolan <th...@yahoo-inc.com> on 2015/05/01 01:33:21 UTC

Re: Review Request 31146: HIVE-9508: MetaStore client socket connection should have a lifetime

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31146/
-----------------------------------------------------------

(Updated April 30, 2015, 11:33 p.m.)


Review request for hive.


Repository: hive-git


Description
-------

HIVE-9508: MetaStore client socket connection should have a lifetime


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 72e4ff2 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 130fd67 
  metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java 5ce58ee 

Diff: https://reviews.apache.org/r/31146/diff/


Testing
-------

1. Added a unit test case.
2. Tested on a live deployment with the fix. The client reconnected after 5 minutes.


Thanks,

Thiruvel Thirumoolan


Re: Review Request 31146: HIVE-9508: MetaStore client socket connection should have a lifetime

Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31146/#review82375
-----------------------------------------------------------

Ship it!


Ship It!

- Vaibhav Gumashta


On April 30, 2015, 11:33 p.m., Thiruvel Thirumoolan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31146/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 11:33 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-9508: MetaStore client socket connection should have a lifetime
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 72e4ff2 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 130fd67 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java 5ce58ee 
> 
> Diff: https://reviews.apache.org/r/31146/diff/
> 
> 
> Testing
> -------
> 
> 1. Added a unit test case.
> 2. Tested on a live deployment with the fix. The client reconnected after 5 minutes.
> 
> 
> Thanks,
> 
> Thiruvel Thirumoolan
> 
>