You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stevedlawrence (via GitHub)" <gi...@apache.org> on 2025/08/28 13:11:04 UTC
[PR] Change withValidation API to accept a URL instead of URI [daffodil]
stevedlawrence opened a new pull request, #1549:
URL: https://github.com/apache/daffodil/pull/1549
The implementation of withValidation currently converts the URI parameter to a URL and then opens it as a stream to provide to the validator. But this conversion implicitly requires the URI to be a valid URL (e.g. has a scheme, can be opened as a stream). We could add documentation to make this more clear, but changing it to a URL makes it much more explicit and ensures our invariants hold.
DAFFODIL-3035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change withValidation API to accept a URL instead of URI [daffodil]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence merged PR #1549:
URL: https://github.com/apache/daffodil/pull/1549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change withValidation API to accept a URL instead of URI [daffodil]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on PR #1549:
URL: https://github.com/apache/daffodil/pull/1549#issuecomment-3237684279
> Do we need to update validation/package-info.java as well. I think the examples there use a URI?
Good catch. Should be fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org