You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/27 02:39:27 UTC

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #30515: [SPARK-33570][SQL][TESTS] Set the proper version of gssapi plugin automatically for MariaDBKrbIntegrationsuite

gaborgsomogyi commented on a change in pull request #30515:
URL: https://github.com/apache/spark/pull/30515#discussion_r531354219



##########
File path: external/docker-integration-tests/src/test/resources/mariadb_docker_entrypoint.sh
##########
@@ -18,7 +18,7 @@
 
 dpkg-divert --add /bin/systemctl && ln -sT /bin/true /bin/systemctl
 apt update
-apt install -y mariadb-plugin-gssapi-server=1:10.5.5+maria~focal
+apt install -y mariadb-plugin-gssapi-server=$(dpkg -s mariadb-server | sed -n "s/^Version: \(.*\)/\1/p")

Review comment:
       The version can be seen under any circumstances in the log but doesn't hurt to add.
   When works fine:
   ```
   Preparing to unpack .../6-mariadb-plugin-gssapi-server_1%3a10.5.8+maria~focal_amd64.deb ...
   ```
   When failed:
   ```
   E: Version '1:10.5.5+maria~focal' for 'mariadb-plugin-gssapi-server' was not found
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org