You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/16 01:14:23 UTC

[GitHub] [airflow] jedcunningham commented on pull request #21294: Adding missing login provider related methods from Flask-Appbuilder

jedcunningham commented on pull request #21294:
URL: https://github.com/apache/airflow/pull/21294#issuecomment-1040983642


   @aa3pankaj, can you fix the conflict in `setup.cfg`? Also can you add a comment explaining why we are pinning FAB?
   
   @potiuk, do you think we should accept a range here, with a strict upper bound instead? e.g from the current `flask-appbuilder~=3.4, <4.0.0` to `flask-appbuilder~=3.4, <=3.4.4` instead of pinning to only `3.4.4`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org