You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/22 17:08:50 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #8026: ARROW-9831: [Rust][DataFusion] Fixed compilation error
jorgecarleitao opened a new pull request #8026:
URL: https://github.com/apache/arrow/pull/8026
@andygrove , the commit that we just merged to master was not aligned with master, causing the code to fail to compile :(
This fixes the compilation, but there are still failing tests. I am working on them...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #8026: ARROW-9831: [Rust][DataFusion] Fixed compilation error
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8026:
URL: https://github.com/apache/arrow/pull/8026#issuecomment-678667466
I disabled some tests. :et's see if this passes.
I am really sorry about that. It is not very clear from github's UI that the PR is not rebased on top of master and thus merges can break master, but I should have remembered that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove closed pull request #8026: ARROW-9831: [Rust][DataFusion] Fixed compilation error
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #8026:
URL: https://github.com/apache/arrow/pull/8026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #8026: ARROW-9831: [Rust][DataFusion] Fixed compilation error
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8026:
URL: https://github.com/apache/arrow/pull/8026#issuecomment-678666746
maybe ignore the tests in this PR so we can merge, then follow up with fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #8026: ARROW-9831: [Rust][DataFusion] Fixed compilation error
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8026:
URL: https://github.com/apache/arrow/pull/8026#issuecomment-678669613
@andygrove clippy failed, but meanwhile I pushed a fix and re-enabled them.
It was a bug on the projection push down that was only shown after you added that check to verify the plans. Really good call on introducing that check; it is the second time that it catches a bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8026: ARROW-9831: [Rust][DataFusion] Fixed compilation error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8026:
URL: https://github.com/apache/arrow/pull/8026#issuecomment-678666613
https://issues.apache.org/jira/browse/ARROW-9831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org