[GitHub] [doris] HappenLee commented on a diff in pull request #13193: [feature](function) support `initcap` string function in vectorized engine.

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #13193:
URL: https://github.com/apache/doris/pull/13193#discussion_r990724580


##########
be/src/vec/functions/function_string.cpp:
##########
@@ -265,6 +265,45 @@ struct TransferImpl {
     }
 };
 
+// Capitalize first letter
+struct NameToInitcap {
+    static constexpr auto name = "initcap";
+};
+
+struct InitcapImpl {
+    static Status vector(const ColumnString::Chars& data, const ColumnString::Offsets& offsets,
+                         ColumnString::Chars& res_data, ColumnString::Offsets& res_offsets) {
+        size_t offset_size = offsets.size();
+        res_offsets.resize(offsets.size());

Review Comment:
   here maybe need memcpy， the offset do not change



##########
be/src/exprs/string_functions.cpp:
##########
@@ -350,6 +350,29 @@ StringVal StringFunctions::upper(FunctionContext* context, const StringVal& str)
     return result;
 }
 
+StringVal StringFunctions::initcap(FunctionContext* context, const StringVal& str) {
+    if (str.is_null) {
+        return StringVal::null();
+    }
+    StringVal result(context, str.len);
+    if (UNLIKELY(result.is_null)) {

Review Comment:
   seems not will be null



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org