[jira] [Comment Edited] (TEZ-3745) Change master to required java 8

["Siddharth Seth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035080#comment-16035080 ] 

Siddharth Seth edited comment on TEZ-3745 at 6/2/17 5:26 PM:
-------------------------------------------------------------

[~jeagles] - thanks for taking a look and committing this. The precommit would never have worked because of the requried jdk change / doclint being disabled.
Didn't want to remove tez-ui... that was a local patch for faster compiles. 

Looks like the last run that you started manually went though.
https://builds.apache.org/job/PreCommit-TEZ-Build/2514/console
{code}
{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12870996/TEZ-3732.3.patch
  against master revision 0ee044c.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2514//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2514//console

This message is automatically generated.
{code}


was (Author: sseth):
[~jeagles] - thanks for taking a look and committing this. The precommit would never have worked because of the requried jdk change / doclint being disabled.
Didn't want to remove tez-ui... that was a local patch for faster compiles. 

> Change master to required java 8
> --------------------------------
>
>                 Key: TEZ-3745
>                 URL: https://issues.apache.org/jira/browse/TEZ-3745
>             Project: Apache Tez
>          Issue Type: Task
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>            Priority: Blocker
>             Fix For: 0.9.0
>
>         Attachments: TEZ-3745.01.patch, TEZ-3745.02.patch, TEZ-3745.03.patch, TEZ-3745.04.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)