[GitHub] [cassandra-accord] aweisberg commented on a diff in pull request #14: Invalidation fixes/improvements

[GitBox <gi...@apache.org>]

aweisberg commented on code in PR #14:
URL: https://github.com/apache/cassandra-accord/pull/14#discussion_r1037286344


##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -979,6 +985,9 @@ else if (existingRanges != additionalRanges && !route().covers(additionalRanges)
         if (!validate(ensurePartialTxn, existingRanges, additionalRanges, covers(partialTxn()), covers(partialTxn), "txn", partialTxn))
             return false;
 
+        if (partialTxn != null && kind() != null && !kind().equals(partialTxn.kind()))
+            throw new IllegalArgumentException("Transaction has different kind to the definition we previously received");

Review Comment:
   What was the bug here? How could kind change during the life of a txn?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org