[jira] [Commented] (NIFI-5175) NiFi built with Java 1.8 needs to run on Java 9

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477655#comment-16477655 ] 

ASF GitHub Bot commented on NIFI-5175:
--------------------------------------

GitHub user jtstorck opened a pull request:

    https://github.com/apache/nifi/pull/2708

    NIFI-5175 Updated NiFi compiled on Java 1.8 to run on Java 9

    The bootstrap process (RunNiFi) detects Java 9 and adds "--add-modules=java.xml.bind" to the command to start NiFi
    Updated OSUtils to detect Java 9 and reflectively invoke the Process.pid() method to get the PID of the NiFi process
    Added java debug variable to nifi.sh to allow debugging of the bootstrap process (RunNiFi)
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jtstorck/nifi NIFI-5175

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2708
    
----
commit 1c71a1cce7745ed476441230a7e2e18e2a78192a
Author: Jeff Storck <jt...@...>
Date:   2018-02-12T20:58:35Z

    NIFI-5175 Updated NiFi compiled on Java 1.8 to run on Java 9
    The bootstrap process (RunNiFi) detects Java 9 and adds "--add-modules=java.xml.bind" to the command to start NiFi
    Updated OSUtils to detect Java 9 and reflectively invoke the Process.pid() method to get the PID of the NiFi process
    Added java debug variable to nifi.sh to allow debugging of the bootstrap process (RunNiFi)

----


> NiFi built with Java 1.8 needs to run on Java 9
> -----------------------------------------------
>
>                 Key: NIFI-5175
>                 URL: https://issues.apache.org/jira/browse/NIFI-5175
>             Project: Apache NiFi
>          Issue Type: Sub-task
>            Reporter: Jeff Storck
>            Assignee: Jeff Storck
>            Priority: Major
>
> The following issues have been encountered while attempting to run a Java 1.8-built NiFi on Java 9:
> ||Issue||Solution||Status||
> |JAXB classes cannot be found on the classpath|Add "--add-modules=java.xml.bind" to the commant that starts NiFi|Done|
> |NiFI boostrap not able to determine PID, restarts nifi after nifi.sh stop|Detect if NiFi is running on Java 9, and reflectively invoke Process.pid(), which was newly added to the Process API in Java 9|Done|
>  
> ----
>  
> ||Unaddressed issues/warnings with NiFi compiled on Java 1.8 running on Java 9+||Description||Solution||
> |WARNING: An illegal reflective access operation has occurred
>  ..._specific class usage snipped_...
>  WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
>  WARNING: All illegal access operations will be denied in a future release|Reflective invocations are common in the code used in NiFi and its dependencies in Java 1.8|Full compliant migration to Java 9 and use dependencies that are Java 9 compliant|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)