You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/10/16 20:32:49 UTC
[GitHub] [incubator-gobblin] Will-Lo opened a new pull request #3129: work in progress to upgrade to gradle 5
Will-Lo opened a new pull request #3129:
URL: https://github.com/apache/incubator-gobblin/pull/3129
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io commented on pull request #3129: work in progress to upgrade to gradle 5
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3129:
URL: https://github.com/apache/incubator-gobblin/pull/3129#issuecomment-711413001
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=h1) Report
> Merging [#3129](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/dec03666692a2aa20307fd5266538023a85348bc?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3129 +/- ##
============================================
- Coverage 46.03% 46.01% -0.02%
+ Complexity 9584 9579 -5
============================================
Files 1986 1986
Lines 75808 75804 -4
Branches 8446 8446
============================================
- Hits 34896 34884 -12
- Misses 37633 37643 +10
+ Partials 3279 3277 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/gobblin/util/hadoop/TokenUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvaGFkb29wL1Rva2VuVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `32.23% <0.00%> (-8.27%)` | `12.00% <0.00%> (-2.00%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `92.85% <0.00%> (-7.15%)` | `3.00% <0.00%> (-1.00%)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0.00%> (-1.43%)` | `4.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==) | `14.43% <0.00%> (-0.78%)` | `4.00% <0.00%> (-1.00%)` | |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `94.59% <0.00%> (-0.15%)` | `4.00% <0.00%> (-1.00%)` | |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `94.59% <0.00%> (-0.15%)` | `4.00% <0.00%> (-1.00%)` | |
| [...c/main/java/org/apache/gobblin/cli/JobCommand.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi1hZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jbGkvSm9iQ29tbWFuZC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `59.27% <0.00%> (+2.06%)` | `27.00% <0.00%> (+2.00%)` | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=footer). Last update [dec0366...8ab56fd](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3129: [GOBBLIN-1293] Upgrades Gradle version to 5.6
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3129:
URL: https://github.com/apache/incubator-gobblin/pull/3129#issuecomment-711413001
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=h1) Report
> Merging [#3129](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/13a66e6cb5e44573191bd58189a799378deea8e2?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3129 +/- ##
=========================================
Coverage 46.01% 46.02%
- Complexity 9579 9582 +3
=========================================
Files 1986 1986
Lines 75807 75805 -2
Branches 8446 8446
=========================================
+ Hits 34886 34890 +4
+ Misses 37642 37638 -4
+ Partials 3279 3277 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0.00%> (-7.15%)` | `3.00% <0.00%> (ø%)` | |
| [...gobblin/service/modules/core/GitConfigMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0dpdENvbmZpZ01vbml0b3IuamF2YQ==) | `81.35% <0.00%> (-1.70%)` | `8.00% <0.00%> (-1.00%)` | |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `94.59% <0.00%> (-0.15%)` | `4.00% <0.00%> (-1.00%)` | |
| [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `94.59% <0.00%> (-0.15%)` | `4.00% <0.00%> (-1.00%)` | |
| [...c/main/java/org/apache/gobblin/cli/JobCommand.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi1hZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jbGkvSm9iQ29tbWFuZC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...c/main/java/org/apache/gobblin/util/AvroUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQXZyb1V0aWxzLmphdmE=) | `57.04% <0.00%> (+0.09%)` | `81.00% <0.00%> (ø%)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `38.01% <0.00%> (+0.82%)` | `14.00% <0.00%> (+1.00%)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `62.85% <0.00%> (+1.42%)` | `4.00% <0.00%> (ø%)` | |
| [.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh) | `79.68% <0.00%> (+1.56%)` | `16.00% <0.00%> (+1.00%)` | |
| [...ava/org/apache/gobblin/fsm/FiniteStateMachine.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3129/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZzbS9GaW5pdGVTdGF0ZU1hY2hpbmUuamF2YQ==) | `76.51% <0.00%> (+3.03%)` | `21.00% <0.00%> (+3.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=footer). Last update [13a66e6...4e48aaf](https://codecov.io/gh/apache/incubator-gobblin/pull/3129?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on pull request #3129: work in progress to upgrade to gradle 5
Posted by GitBox <gi...@apache.org>.
autumnust commented on pull request #3129:
URL: https://github.com/apache/incubator-gobblin/pull/3129#issuecomment-710747058
You may also want to check the travis failure. Looks like something wrong with the azkaban module.
Also, let me know if you are able to create JIRA issue in Gobblin board https://issues.apache.org/jira/projects/GOBBLIN/summary, and with the issue created there could you also fill the issue link in the PR-description template ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3129: work in progress to upgrade to gradle 5
Posted by GitBox <gi...@apache.org>.
autumnust commented on a change in pull request #3129:
URL: https://github.com/apache/incubator-gobblin/pull/3129#discussion_r506792323
##########
File path: gobblin-modules/gobblin-elasticsearch-deps/build.gradle
##########
@@ -21,7 +21,7 @@ buildscript {
jcenter()
}
dependencies {
- classpath 'com.github.jengelman.gradle.plugins:shadow:2.0.4'
+ classpath 'com.github.jengelman.gradle.plugins:shadow:4.0.4'
Review comment:
You may want to add a comment for the reasons why it needs to be upgraded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3129: [GOBBLIN-1293] Upgrades Gradle version to 5.6
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3129:
URL: https://github.com/apache/incubator-gobblin/pull/3129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org