You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/02 20:00:40 UTC
[GitHub] [maven-indexer] cstamas opened a new pull request, #207: Make project Java 11
cstamas opened a new pull request, #207:
URL: https://github.com/apache/maven-indexer/pull/207
Changes:
- requires latest Java LTS to build
- requires latest Maven to build
- uses `--release` to set Java 11 level
- drop animal sniffer as JDK does all now
Thr goal is to keep project stick to latest LTS Java, latest Maven
and then target the required Java level using new release switch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] cstamas commented on a diff in pull request #207: Make project Java 11
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #207:
URL: https://github.com/apache/maven-indexer/pull/207#discussion_r863645294
##########
.github/workflows/maven-verify.yml:
##########
@@ -25,5 +25,9 @@ jobs:
build:
name: Verify
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
+ with:
+ ff-jdk: '17'
+ maven_version: 3.8.5
+ jdk-matrix: '[ "17" ]'
Review Comment:
See here https://github.com/apache/maven-indexer/pull/207#issuecomment-1115316420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] cstamas commented on a diff in pull request #207: Make project Java 11
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #207:
URL: https://github.com/apache/maven-indexer/pull/207#discussion_r863173183
##########
pom.xml:
##########
@@ -84,7 +84,12 @@ under the License.
</distributionManagement>
<properties>
- <javaVersion>8</javaVersion>
+ <javaVersion>11</javaVersion>
+ <maven.compiler.source>${javaVersion}</maven.compiler.source>
Review Comment:
It's in parent, so here is just redefined (as see in parent what is happening), and yes, it works as release is set... basically, just to be aligned if some tool relies on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] cstamas commented on pull request #207: Make project Java 11
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #207:
URL: https://github.com/apache/maven-indexer/pull/207#issuecomment-1115314692
I'd need some help with GH Actions to set mvn ONLY to 3.8.5 and JDK ONLY to 17.... Tx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] cstamas commented on pull request #207: Make project Java 11
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #207:
URL: https://github.com/apache/maven-indexer/pull/207#issuecomment-1115316420
@khmarbaise @gnodet Soon I'd like to make indexer a "guinea pig" to set it up as one of you mentioned on one of the Aperos:
* require latest LTS Java to build it
* require latest "stable" Maven (3.8.5 is good, IMHO should not touch it even once 3.9.0 is out, but once 4.0.1 is out, I will bump it to it)
* set release to minimal required (by libs, Lucene 9 is Java 11)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] cstamas commented on a diff in pull request #207: Make project Java 11
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #207:
URL: https://github.com/apache/maven-indexer/pull/207#discussion_r863175317
##########
pom.xml:
##########
@@ -84,7 +84,12 @@ under the License.
</distributionManagement>
<properties>
- <javaVersion>8</javaVersion>
+ <javaVersion>11</javaVersion>
+ <maven.compiler.source>${javaVersion}</maven.compiler.source>
Review Comment:
See parent here https://github.com/apache/maven-parent/blob/46af4d6a5cf3b49a116e2f52e17c8343e33805e2/pom.xml#L928-L930 (this commit is parent v 36)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] slawekjaranowski commented on a diff in pull request #207: Make project Java 11
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #207:
URL: https://github.com/apache/maven-indexer/pull/207#discussion_r863644700
##########
.github/workflows/maven-verify.yml:
##########
@@ -25,5 +25,9 @@ jobs:
build:
name: Verify
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
+ with:
+ ff-jdk: '17'
+ maven_version: 3.8.5
+ jdk-matrix: '[ "17" ]'
Review Comment:
Why only 17?
You can exclude only jdk 8
```
matrix-exclude: >
[ {"jdk": "8"} ]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] pzygielo commented on a diff in pull request #207: Make project Java 11
Posted by GitBox <gi...@apache.org>.
pzygielo commented on code in PR #207:
URL: https://github.com/apache/maven-indexer/pull/207#discussion_r863169718
##########
pom.xml:
##########
@@ -84,7 +84,12 @@ under the License.
</distributionManagement>
<properties>
- <javaVersion>8</javaVersion>
+ <javaVersion>11</javaVersion>
+ <maven.compiler.source>${javaVersion}</maven.compiler.source>
Review Comment:
What this is for? Given that
```
error: option -source cannot be used together with --release
error: option -target cannot be used together with --release
Usage: javac <options> <source files>
use --help for a list of possible options
```
and if release is set (and in new line 359 it is) - source/target are not used by compiler-plugin anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] cstamas merged pull request #207: [MINDEXER-161] Make project Java 11
Posted by GitBox <gi...@apache.org>.
cstamas merged PR #207:
URL: https://github.com/apache/maven-indexer/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org