You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/21 20:52:03 UTC

[GitHub] [spark] amaliujia commented on a diff in pull request #36947: [SPARK-39548][SQL] CreateView Command with a window clause query hit a wrong window definition not found issue

amaliujia commented on code in PR #36947:
URL: https://github.com/apache/spark/pull/36947#discussion_r903057670


##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -4449,6 +4449,28 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
         """.stripMargin),
       Seq(Row(2), Row(1)))
   }
+
+  test("CreateView will make query go into inline CTE code path") {

Review Comment:
   I will update this test case name after the initial review.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org