[GitHub] [arrow-rs] ovr commented on a diff in pull request #2052: feat(compute): Support week0 (PostgreSQL behaviour) for temporal

[GitBox <gi...@apache.org>]

ovr commented on code in PR #2052:
URL: https://github.com/apache/arrow-rs/pull/2052#discussion_r920515028


##########
arrow/src/compute/kernels/temporal.rs:
##########
@@ -112,31 +112,28 @@ macro_rules! return_compute_error_with {
     };
 }
 
-trait ChronoDateQuarter {
+// Internal trait, which is used for mapping values from DateLike structures
+trait ChronoDateExt {
     /// Returns a value in range `1..=4` indicating the quarter this date falls into
     fn quarter(&self) -> u32;
 
     /// Returns a value in range `0..=3` indicating the quarter (zero-based) this date falls into
     fn quarter0(&self) -> u32;
+
+    fn weekday0(&self) -> i32;
 }
 
-impl ChronoDateQuarter for NaiveDateTime {
+impl<T: Datelike> ChronoDateExt for T {
     fn quarter(&self) -> u32 {
         self.quarter0() + 1
     }
 
     fn quarter0(&self) -> u32 {
         self.month0() / 3
     }
-}
-
-impl ChronoDateQuarter for NaiveDate {
-    fn quarter(&self) -> u32 {
-        self.quarter0() + 1
-    }
 
-    fn quarter0(&self) -> u32 {
-        self.month0() / 3
+    fn weekday0(&self) -> i32 {
+        self.weekday().num_days_from_sunday() as i32

Review Comment:
   ✅ done in https://github.com/apache/arrow-rs/pull/2052/commits/6e8070226678939bf9ccd44f03fe5768933b5e24
   
   is it ok?
   
   Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org