[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #642: OAK-9873 Prefetch node states: composite node store support

[GitBox <gi...@apache.org>]

thomasmueller commented on code in PR #642:
URL: https://github.com/apache/jackrabbit-oak/pull/642#discussion_r933289347


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/prefetch/CacheWarming.java:
##########
@@ -48,6 +52,9 @@ public void prefetch(@NotNull Iterable<String> paths,
                 ids.add(id);
             }
         }
+        if (LOG.isDebugEnabled()) {
+            LOG.debug("Prefetch {} nodes", ids.size());
+        }

Review Comment:
   > does calling LOG.isDebugEnabled() actually helps performance in this case?
   
   Probably it doesn't help currently, except if ids.size() is slow.
   I just wanted to avoid any kind of risks, including the risk that someone might later add more data, that ids is null, things like that.
   It's more following the pattern that all LOG.debug are behind LOG.isDebugEnabled()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org