You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/03/08 10:31:18 UTC

[GitHub] [incubator-dolphinscheduler] liwenhe1993 edited a comment on issue #2113: access field handle of FileDescriptor in ProcessImplForWin32 by reflection for portability

liwenhe1993 edited a comment on issue #2113: access field handle of FileDescriptor in ProcessImplForWin32 by reflection for portability
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2113#issuecomment-596189984
 
 
   Yeah, I will do, but UT run failed.
   ```
   Tests in error: 
     ShellTaskTest.testHandleForWindows:179 NullPointer
   ```
   
   **Maybe ocurred error by:** 
   ```java
   static {
       try {
           FD_HANDLE = FileDescriptor.class.getDeclaredField("handle");
           FD_HANDLE.setAccessible(true);
       } catch (NoSuchFieldException e) {
           throw new RuntimeException(e);
       }
   }
   ```
   
   **So, UT should be updated.**

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services