You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "raiden00pl (via GitHub)" <gi...@apache.org> on 2023/08/21 11:48:19 UTC

[GitHub] [nuttx-apps] raiden00pl opened a new pull request, #1985: rptun/ping: fix invalid use of nsh_error after 31421db6f

raiden00pl opened a new pull request, #1985:
URL: https://github.com/apache/nuttx-apps/pull/1985

   ## Summary
   rptun/ping: fix invalid use of nsh_error after 31421db6f
   
   reported by CI:
   ```
    Error: nsh_syscmds.c:541:27: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
             nsh_error(vtbl, g_fmtargrequired);
                             ^~~~~~~~~~~~~~~~
   ./nsh_console.h:54:49: note: expanded from macro 'nsh_error'
   #  define nsh_error(v, ...)     (v)->error(v, ##__VA_ARGS__)
                                                   ^~~~~~~~~~~
   nsh_syscmds.c:541:27: note: treat the string as an argument to avoid this
             nsh_error(vtbl, g_fmtargrequired);
                             ^
                             "%s", 
   ./nsh_console.h:54:49: note: expanded from macro 'nsh_error'
   #  define nsh_error(v, ...)     (v)->error(v, ##__VA_ARGS__)
   ```
   ## Impact
   
   ## Testing
   CI, I don't get this error locally
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx-apps] pkarashchenko merged pull request #1985: rptun/ping: fix invalid use of nsh_error after 31421db6f

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #1985:
URL: https://github.com/apache/nuttx-apps/pull/1985


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org