You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by jg...@apache.org on 2017/07/25 08:15:34 UTC
[5/8] tomee git commit: Fix the
testGetFromFederatedContextPropagatesReadOnlyFlag() test
Fix the testGetFromFederatedContextPropagatesReadOnlyFlag() test
The test was adjusted to the buggy behaviour so it can just pass,
but instead of building teh desired test IvmContext (comp/env/test),
it was actually building (comp/comp/env/test). The test was passing
because doe to TOMEE-2102, teh IvmContext was creating two alternative
NameNodes for "comp". So the lookup relative to comp was working,
but if the same was attempted relative to the root node, it would have failed.
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/7af9eb4c
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/7af9eb4c
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/7af9eb4c
Branch: refs/heads/master
Commit: 7af9eb4ccbdf3f38eb2312c9c9b265a5b6b1edbf
Parents: 5eae4d0
Author: Svetlin Zarev <sv...@sap.com>
Authored: Thu Jul 20 12:10:20 2017 +0300
Committer: Svetlin Zarev <sv...@sap.com>
Committed: Thu Jul 20 12:10:20 2017 +0300
----------------------------------------------------------------------
.../java/org/apache/openejb/core/ivm/naming/IvmContextTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tomee/blob/7af9eb4c/container/openejb-core/src/test/java/org/apache/openejb/core/ivm/naming/IvmContextTest.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/test/java/org/apache/openejb/core/ivm/naming/IvmContextTest.java b/container/openejb-core/src/test/java/org/apache/openejb/core/ivm/naming/IvmContextTest.java
index 6b8b1cf..e52c5e6 100644
--- a/container/openejb-core/src/test/java/org/apache/openejb/core/ivm/naming/IvmContextTest.java
+++ b/container/openejb-core/src/test/java/org/apache/openejb/core/ivm/naming/IvmContextTest.java
@@ -324,7 +324,7 @@ public class IvmContextTest extends TestCase {
public void testGetFromFederatedContextPropagatesReadOnlyFlag() throws NamingException {
final IvmContext context = new IvmContext();
final IvmContext federatedContext = new IvmContext("comp");
- federatedContext.bind("comp/env/test", "test");
+ federatedContext.bind("env/test", "test");
context.bind("", federatedContext);
context.setReadOnly(true);