You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2019/02/22 18:02:30 UTC

[GitHub] risdenk commented on a change in pull request #57: KNOX-1191 - Azure AD support for KnoxSSO

risdenk commented on a change in pull request #57: KNOX-1191 - Azure AD support for KnoxSSO
URL: https://github.com/apache/knox/pull/57#discussion_r259451288
 
 

 ##########
 File path: gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/session/KnoxSessionStore.java
 ##########
 @@ -176,6 +211,25 @@ public void set(WebContext context, String key, Object value) {
         }
     }
 
+    /**
+     * Keep only the fileds that are needed for Pac4J.
+     * Used to reduce the cookie size.
+     * @param value profile object
+     * @return trimmed profile object
+     * @since 1.3.0
+     */
+    private Object clearUserProfile(final Object value) {
+        if(value instanceof LinkedHashMap<?,?>) {
 
 Review comment:
   Could this be any Map instead of a LinkedHashMap? Just thinking if profiles Map impl could change later but would still have the same underlying interface.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services