You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2026/10/20 10:22:38 UTC

[PR] GH-51481: [Python] Fix dlpack related deprecation warnings [arrow]

AlenkaF opened a new pull request, #54690:
URL: https://github.com/apache/arrow/pull/54690

   ### Rationale for this change
   Deprecation warnings on our CI.
   
   ### What changes are included in this PR?
   Added filterwarning marks and updated two tests.
   
   ### Are these changes tested?
   Yes.
   
   ### Are there any user-facing changes?
   No.
   
   ### Was AI used for this PR?
   
   **PR code and description written by:**
   
   - [X] Human
   - [ ] AI
   
   **Reviewed before submission by:**
   
   - [X] Human
   - [ ] AI
   - [ ] Not reviewed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-51481: [Python] Fix dlpack related deprecation warnings [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #54690:
URL: https://github.com/apache/arrow/pull/54690#issuecomment-6289049728

   @github-actions crossbow submit *cuda-python*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-51481: [Python] Fix dlpack related deprecation warnings [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #54690:
URL: https://github.com/apache/arrow/pull/54690#issuecomment-6288892783

   @github-actions crossbow submit test-cuda-python-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-51481: [Python] Fix dlpack related deprecation warnings [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #54690:
URL: https://github.com/apache/arrow/pull/54690#issuecomment-6288869849

   @github-actions crossbow submit test-conda-python-3.14-pandas-nightly-numpy-nightly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-51481: [Python] Fix dlpack related deprecation warnings [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54690:
URL: https://github.com/apache/arrow/pull/54690#issuecomment-6290837449

   Revision: d76834e8ffb7fa51e73ef7087905572cad14a306
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-2c39a144ec](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2c39a144ec)
   
   |Task|Status|
   |----|------|
   |test-conda-python-3.14-pandas-nightly-numpy-nightly|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-2c39a144ec-github-test-conda-python-3.14-pandas-nightly-numpy-nightly)](https://github.com/ursacomputing/crossbow/actions/runs/39422358045/job/118626234288)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-51481: [Python] Fix dlpack related deprecation warnings [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54690:
URL: https://github.com/apache/arrow/pull/54690#issuecomment-6288909403

   ```
   Unable to match any tasks for `test-cuda-python-*`
   The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/39408461413
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-51481: [Python] Fix dlpack related deprecation warnings [arrow]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #54690:
URL: https://github.com/apache/arrow/pull/54690#discussion_r4336641478


##########
python/pyarrow/tests/test_dlpack.py:
##########
@@ -331,28 +334,36 @@ def test_dlpack_copy_is_writeable():
     assert arr.to_pylist() == [1, 2, 3]
 
 
+def from_dlpack_split(obj):
+    if Version(np.__version__) < Version("2.1.0"):
+        max_version = None
+    else:
+        max_version = (1, 0)
+    return np.from_dlpack(DLPackForwarder(obj, max_version=max_version))
+
+
 def test_dlpack_not_supported():

Review Comment:
   For NumPy <2.1, `max_version=None` still emits the legacy-capsule warning before `Array.__dlpack__` raises the expected export error. Wheel tests use NumPy 2.0 on Python <=3.12 (`python/requirements-wheel-test.txt:15`), so `test_dlpack_not_supported` still produces the warnings this PR targets and fails when deprecations are treated as errors. Add a targeted warning filter to that test, as with the other legacy tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-51481: [Python] Fix dlpack related deprecation warnings [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #54690:
URL: https://github.com/apache/arrow/pull/54690#issuecomment-6290749664

   @github-actions crossbow submit test-conda-python-3.14-pandas-nightly-numpy-nightly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-51481: [Python] Fix dlpack related deprecation warnings [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54690:
URL: https://github.com/apache/arrow/pull/54690#issuecomment-6289068355

   ```
   Unable to match any tasks for `*cuda-python*`
   The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/39409603500
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-51481: [Python] Fix dlpack related deprecation warnings [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54690:
URL: https://github.com/apache/arrow/pull/54690#issuecomment-6288906671

   Revision: 0b0547b00822a5b23e64db9101bf5c07de24a4b1
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-f4784d40eb](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f4784d40eb)
   
   |Task|Status|
   |----|------|
   |test-conda-python-3.14-pandas-nightly-numpy-nightly|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f4784d40eb-github-test-conda-python-3.14-pandas-nightly-numpy-nightly)](https://github.com/ursacomputing/crossbow/actions/runs/39408435453/job/118579976625)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org