[GitHub] [spark] gengliangwang commented on a diff in pull request #39945: [SPARK-42384][SQL] Check for null input in generated code for mask function

["gengliangwang (via GitHub)" <gi...@apache.org>]

gengliangwang commented on code in PR #39945:
URL: https://github.com/apache/spark/pull/39945#discussion_r1106820755


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala:
##########
@@ -223,16 +223,32 @@ case class Mask(
     val fifthGen = children(4).genCode(ctx)
     val resultCode =
       f(firstGen.value, secondGen.value, thirdGen.value, fourthGen.value, fifthGen.value)
-    ev.copy(
-      code = code"""
+    if (nullable) {

Review Comment:
   @bersprockets Have you tried using the `NullIntolerant` trait on the expression `Mask` instead? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org