[jira] [Commented] (YUNIKORN-3475) Remove stack and fullstatedump redirects from routes

["TingYao Huang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118866#comment-18118866 ] 

TingYao Huang commented on YUNIKORN-3475:
-----------------------------------------

Hi [~wilfreds] , could you confirm we still want to remove these redirects?

 
The code comment says they go in 1.10, but branch-1.10 has already been cut, so I set the fix version to 1.11.0, like we did for YUNIKORN-3234. If you'd rather cherry-pick this into branch-1.10, or keep the redirects for longer, let me know.
 
Note: this change removes \{{Test_RedirectDebugHandler}}, which [YUNIKORN-3470|https://issues.apache.org/jira/browse/YUNIKORN-3470] is currently fixing. The \{{Test_RouterHandling}} part of that fix is still needed.

> Remove stack and fullstatedump redirects from routes
> ----------------------------------------------------
>
>                 Key: YUNIKORN-3475
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-3475
>             Project: Apache YuniKorn
>          Issue Type: Task
>          Components: core - common
>            Reporter: TingYao Huang
>            Priority: Major
>              Labels: release-notes
>
> The {{/ws/v1/stack}} and {{/ws/v1/fullstatedump}} endpoints were moved to {{/debug/...}} in YuniKorn 1.7 (YUNIKORN-2965) and only redirect since then. The code comments mark the redirects for removal in 1.10. We did not track this and 1.10 has already branched, so adding for 1.11 (same as YUNIKORN-3234 for node-utilization).
> Changes:
> * core: remove the two routes, {{redirectDebug()}} and its tests
> * k8shim: the e2e framework still uses {{ws/v1/fullstatedump}} ({{FullStateDumpPath}}) through the redirect, as already noted in YUNIKORN-2965. Without the redirect the state dump for failed specs is silently lost. Switch to {{debug/fullstatedump}}; this is safe before the core change.
> * site: remove the deprecated sections from {{docs/api/scheduler.md}}
> After this change the old paths return 404, which needs a release note.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org